From: Ben Gardon <bgardon@google.com>
To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Peter Xu <peterx@redhat.com>,
Sean Christopherson <seanjc@google.com>,
David Matlack <dmatlack@google.com>,
Vipin Sharma <vipinsh@google.com>,
Ricardo Koller <ricarkol@google.com>,
Ben Gardon <bgardon@google.com>
Subject: [PATCH V5 0/2] selftests: KVM: Add a test for eager page splitting
Date: Tue, 31 Jan 2023 18:18:18 +0000 [thread overview]
Message-ID: <20230131181820.179033-1-bgardon@google.com> (raw)
David Matlack recently added a feature known as eager page splitting
to x86 KVM. This feature improves vCPU performance during dirty
logging because the splitting operation is moved out of the page
fault path, avoiding EPT/NPT violations or allowing the vCPU threads
to resolve the violation in the fast path.
While this feature is a great performance improvement, it does not
have adequate testing in KVM selftests. Add a test to provide coverage
of eager page splitting.
Patch 1 is a quick refactor to be able to re-use some code from
dirty_log_perf_test.
Patch 2 adds the actual test.
V4->V5:
- V4: https://lore.kernel.org/all/Y9lIfGtMEEsaw6cd@google.com/
- Separated a helper function to just run vCPUs for an iteration and
not also collect the stats. Suggested by Vipin.
- Added a log message when the host does not support MANUAL_PROTECT,
and so testing with that capability is skipped. Also suggested by
Vipin.
- Added RB from Vipin.
V3->V4:
- Added the copyright notices back. Thanks Vipin for the right
thing to do there.
V2->V3:
- Removed copyright notice from the top of dirty_log_page_splitting.c
- Adopted ASSERT_EQ for test assertions
- Now skipping testing with MANUAL_PROTECT if unsupported
V1->V2:
- Run test in multiple modes, as suggested by David and Ricardo
- Cleanups from shameful copy-pasta, as suggested by David
Ben Gardon (2):
selftests: KVM: Move dirty logging functions to memstress.(c|h)
selftests: KVM: Add dirty logging page splitting test
tools/testing/selftests/kvm/Makefile | 1 +
.../selftests/kvm/dirty_log_perf_test.c | 84 +-----
.../selftests/kvm/include/kvm_util_base.h | 1 +
.../testing/selftests/kvm/include/memstress.h | 8 +
tools/testing/selftests/kvm/lib/kvm_util.c | 5 +
tools/testing/selftests/kvm/lib/memstress.c | 72 +++++
.../x86_64/dirty_log_page_splitting_test.c | 260 ++++++++++++++++++
7 files changed, 354 insertions(+), 77 deletions(-)
create mode 100644 tools/testing/selftests/kvm/x86_64/dirty_log_page_splitting_test.c
--
2.39.1.456.gfc5497dd1b-goog
next reply other threads:[~2023-01-31 18:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 18:18 Ben Gardon [this message]
2023-01-31 18:18 ` [PATCH V5 1/2] selftests: KVM: Move dirty logging functions to memstress.(c|h) Ben Gardon
2023-01-31 18:18 ` [PATCH V5 2/2] selftests: KVM: Add dirty logging page splitting test Ben Gardon
2023-03-14 13:27 ` [PATCH V5 0/2] selftests: KVM: Add a test for eager page splitting Paolo Bonzini
2023-03-14 14:23 ` Paolo Bonzini
2023-03-14 16:00 ` David Matlack
2023-03-15 12:24 ` Paolo Bonzini
2023-03-15 19:08 ` Paolo Bonzini
2023-03-15 19:22 ` Sean Christopherson
2023-03-15 20:49 ` Paolo Bonzini
2023-06-02 1:23 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230131181820.179033-1-bgardon@google.com \
--to=bgardon@google.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=ricarkol@google.com \
--cc=seanjc@google.com \
--cc=vipinsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox