From: Xin Li <xin3.li@intel.com>
To: linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com, peterz@infradead.org,
andrew.cooper3@citrix.com, seanjc@google.com,
pbonzini@redhat.com, ravi.v.shankar@intel.com
Subject: [RFC PATCH v3 26/32] x86/fred: no ESPFIX needed when FRED is enabled
Date: Thu, 23 Feb 2023 23:01:39 -0800 [thread overview]
Message-ID: <20230224070145.3572-27-xin3.li@intel.com> (raw)
In-Reply-To: <20230224070145.3572-1-xin3.li@intel.com>
From: "H. Peter Anvin (Intel)" <hpa@zytor.com>
Because FRED always restores the full value of %rsp, ESPFIX is
no longer needed when it's enabled.
Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
Signed-off-by: Xin Li <xin3.li@intel.com>
---
arch/x86/kernel/espfix_64.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/x86/kernel/espfix_64.c b/arch/x86/kernel/espfix_64.c
index 16f9814c9be0..48d133a54f45 100644
--- a/arch/x86/kernel/espfix_64.c
+++ b/arch/x86/kernel/espfix_64.c
@@ -106,6 +106,10 @@ void __init init_espfix_bsp(void)
pgd_t *pgd;
p4d_t *p4d;
+ /* FRED systems don't need ESPFIX */
+ if (cpu_feature_enabled(X86_FEATURE_FRED))
+ return;
+
/* Install the espfix pud into the kernel page directory */
pgd = &init_top_pgt[pgd_index(ESPFIX_BASE_ADDR)];
p4d = p4d_alloc(&init_mm, pgd, ESPFIX_BASE_ADDR);
@@ -129,6 +133,10 @@ void init_espfix_ap(int cpu)
void *stack_page;
pteval_t ptemask;
+ /* FRED systems don't need ESPFIX */
+ if (cpu_feature_enabled(X86_FEATURE_FRED))
+ return;
+
/* We only have to do this once... */
if (likely(per_cpu(espfix_stack, cpu)))
return; /* Already initialized */
--
2.34.1
next prev parent reply other threads:[~2023-02-24 7:29 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 7:01 [RFC PATCH v3 00/32] x86: enable FRED for x86-64 Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 01/32] x86/traps: let common_interrupt() handle IRQ_MOVE_CLEANUP_VECTOR Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 02/32] x86/traps: add a system interrupt table for system interrupt dispatch Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 03/32] x86/traps: add install_system_interrupt_handler() Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 04/32] x86/traps: add external_interrupt() to dispatch external interrupts Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 05/32] x86/traps: export external_interrupt() for VMX IRQ reinjection Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 06/32] x86/cpufeature: add the cpu feature bit for FRED Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 07/32] x86/opcode: add ERETU, ERETS instructions to x86-opcode-map Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 08/32] x86/objtool: teach objtool about ERETU and ERETS Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 09/32] x86/cpu: add X86_CR4_FRED macro Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 10/32] x86/fred: add Kconfig option for FRED (CONFIG_X86_FRED) Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 11/32] x86/fred: if CONFIG_X86_FRED is disabled, disable FRED support Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 12/32] x86/cpu: add MSR numbers for FRED configuration Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 13/32] x86/fred: header file for event types Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 14/32] x86/fred: header file with FRED definitions Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 15/32] x86/fred: make unions for the cs and ss fields in struct pt_regs Xin Li
2023-02-24 10:59 ` andrew.cooper3
2023-02-24 16:34 ` Li, Xin3
2023-03-01 2:17 ` H. Peter Anvin
2023-03-01 3:17 ` Li, Xin3
2023-02-24 7:01 ` [RFC PATCH v3 16/32] x86/fred: reserve space for the FRED stack frame Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 17/32] x86/fred: add a page fault entry stub for FRED Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 18/32] x86/fred: add a debug " Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 19/32] x86/fred: add a NMI " Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 20/32] x86/fred: add a machine check " Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 21/32] x86/fred: FRED entry/exit and dispatch code Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 22/32] x86/fred: FRED initialization code Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 23/32] x86/fred: update MSR_IA32_FRED_RSP0 during task switch Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 24/32] x86/fred: let ret_from_fork() jmp to fred_exit_user when FRED is enabled Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 25/32] x86/fred: disallow the swapgs instruction " Xin Li
2023-02-24 7:01 ` Xin Li [this message]
2023-02-24 7:01 ` [RFC PATCH v3 27/32] x86/fred: allow single-step trap and NMI when starting a new thread Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 28/32] x86/fred: fixup fault on ERETU by jumping to fred_entrypoint_user Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 29/32] x86/ia32: do not modify the DPL bits for a null selector Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 30/32] x86/fred: allow FRED systems to use interrupt vectors 0x10-0x1f Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 31/32] x86/fred: allow dynamic stack frame size Xin Li
2023-02-24 7:01 ` [RFC PATCH v3 32/32] x86/fred: disable FRED by default in its early stage Xin Li
2023-02-24 9:26 ` [RFC PATCH v3 00/32] x86: enable FRED for x86-64 Kang, Shan
2023-02-28 7:29 ` Li, Xin3
2023-02-24 9:28 ` Kang, Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230224070145.3572-27-xin3.li@intel.com \
--to=xin3.li@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=ravi.v.shankar@intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox