From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43F1FC6FD19 for ; Fri, 10 Mar 2023 08:31:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231158AbjCJIbP (ORCPT ); Fri, 10 Mar 2023 03:31:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230515AbjCJIbE (ORCPT ); Fri, 10 Mar 2023 03:31:04 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A969E9F35 for ; Fri, 10 Mar 2023 00:29:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678436998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0VVY8kly3TcDFN9v8u5UAZIFaG8NcKB7KdRar2p0UPo=; b=X2QL/Iug6y0onMnTzHzHas6syFAZIRhtYaFImQV0rZSskAhUodhBMxkkh2lTSk4sGoUfAk lYVHJkrqXSyzF9vO+DF4+rtJmfbxnF4N8HQPPsqb5VeG4yodpP3oHiX2T2zZ+vncTmud1w ZfDKy1uBczjE6hgHOSufPeVIUanr1zQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-386-DrJFq0RFP0G1-J3RfgyNeg-1; Fri, 10 Mar 2023 03:29:56 -0500 X-MC-Unique: DrJFq0RFP0G1-J3RfgyNeg-1 Received: by mail-wm1-f69.google.com with SMTP id bi27-20020a05600c3d9b00b003e9d0925341so1518725wmb.8 for ; Fri, 10 Mar 2023 00:29:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678436995; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0VVY8kly3TcDFN9v8u5UAZIFaG8NcKB7KdRar2p0UPo=; b=vhZZQiJnmUHjI1hEQXrgKBlvPsj5HmddPrhL88PL00FwSfQq5Ty+We2nS7STneC/JE Xz358/NScGoOIp2N2GBEGbKBUTCTOFH1xFt20cDjU1SATM5/AVjoNiZYpgVW9StgiDE4 OJ+8n4oWfjazMXUrJkqZR+nc3ewLnB6HMWjCztuRpiEGD73dnsTiSKGdMFntTob4drIT 4kMrWezxVLV3NV77Qw1QYF9j9MOir/UCA6pa1b9GQqaNJepJJrWyBqub/h53hyOJEjaT +AXUKGMWs4tmRW6FR+Wrj7dG4si4cC3CYIt/De4Mhq+liyMBmG8tr7soSKHMbSY4cFtz jh6g== X-Gm-Message-State: AO0yUKUdKvTVcxe1ACPFh07LV2qA702zugx2mw2fO4pV9q8GUSUveVza X5d7RMQsugi98MHjZrzqdYeEquCgey0I456t1KdT1shUBNuCQLDyEneK/WuP9JuUVS2xGcyw0m4 Yg/RL42tUnoe+ X-Received: by 2002:a05:600c:46d1:b0:3eb:29fe:fe19 with SMTP id q17-20020a05600c46d100b003eb29fefe19mr1724976wmo.34.1678436994993; Fri, 10 Mar 2023 00:29:54 -0800 (PST) X-Google-Smtp-Source: AK7set/3NDIB2yQpnAOJ1gLOd87qFJtloJUYcD7foQwbKEjLNGWL6NTidbGAfi/e3Esc+ca2i7/9Kw== X-Received: by 2002:a05:600c:46d1:b0:3eb:29fe:fe19 with SMTP id q17-20020a05600c46d100b003eb29fefe19mr1724955wmo.34.1678436994706; Fri, 10 Mar 2023 00:29:54 -0800 (PST) Received: from redhat.com ([2.52.9.88]) by smtp.gmail.com with ESMTPSA id l14-20020a1ced0e000000b003eb20d4d4a8sm1415501wmh.44.2023.03.10.00.29.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 00:29:54 -0800 (PST) Date: Fri, 10 Mar 2023 03:29:49 -0500 From: "Michael S. Tsirkin" To: Ross Zwisler Cc: linux-kernel@vger.kernel.org, Ross Zwisler , "Tobin C. Harding" , Andrew Morton , Jason Wang , Masami Hiramatsu , Paolo Bonzini , Shuah Khan , Tycho Andersen , kvm@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org, linux-trace-kernel@vger.kernel.org, Steven Rostedt Subject: Re: [PATCH v2 0/6] use canonical ftrace path whenever possible Message-ID: <20230310032921-mutt-send-email-mst@kernel.org> References: <20230215223350.2658616-1-zwisler@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230215223350.2658616-1-zwisler@google.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Feb 15, 2023 at 03:33:44PM -0700, Ross Zwisler wrote: > Changes in v2: > * Dropped patches which were pulled into maintainer trees. > * Split BPF patches out into another series targeting bpf-next. > * trace-agent now falls back to debugfs if tracefs isn't present. > * Added Acked-by from mst@redhat.com to series. > * Added a typo fixup for the virtio-trace README. > > Steven, assuming there are no objections, would you feel comfortable > taking this series through your tree? Acked-by: Michael S. Tsirkin if you want the virtio patches through my tree after all, let me know. > --- > The canonical location for the tracefs filesystem is at /sys/kernel/tracing. > > But, from Documentation/trace/ftrace.rst: > > Before 4.1, all ftrace tracing control files were within the debugfs > file system, which is typically located at /sys/kernel/debug/tracing. > For backward compatibility, when mounting the debugfs file system, > the tracefs file system will be automatically mounted at: > > /sys/kernel/debug/tracing > > There are many places where this older debugfs path is still used in > code comments, selftests, examples and tools, so let's update them to > avoid confusion. > > I've broken up the series as best I could by maintainer or directory, > and I've only sent people the patches that I think they care about to > avoid spamming everyone. > > Ross Zwisler (6): > tracing: always use canonical ftrace path > selftests: use canonical ftrace path > leaking_addresses: also skip canonical ftrace path > tools/kvm_stat: use canonical ftrace path > tools/virtio: use canonical ftrace path > tools/virtio: fix typo in README instructions > > include/linux/kernel.h | 2 +- > include/linux/tracepoint.h | 4 ++-- > kernel/trace/Kconfig | 20 +++++++++---------- > kernel/trace/kprobe_event_gen_test.c | 2 +- > kernel/trace/ring_buffer.c | 2 +- > kernel/trace/synth_event_gen_test.c | 2 +- > kernel/trace/trace.c | 2 +- > samples/user_events/example.c | 4 ++-- > scripts/leaking_addresses.pl | 1 + > scripts/tracing/draw_functrace.py | 6 +++--- > tools/kvm/kvm_stat/kvm_stat | 2 +- > tools/lib/api/fs/tracing_path.c | 4 ++-- > .../testing/selftests/user_events/dyn_test.c | 2 +- > .../selftests/user_events/ftrace_test.c | 10 +++++----- > .../testing/selftests/user_events/perf_test.c | 8 ++++---- > tools/testing/selftests/vm/protection_keys.c | 4 ++-- > tools/tracing/latency/latency-collector.c | 2 +- > tools/virtio/virtio-trace/README | 4 ++-- > tools/virtio/virtio-trace/trace-agent.c | 12 +++++++---- > 19 files changed, 49 insertions(+), 44 deletions(-) > > -- > 2.39.1.637.g21b0678d19-goog