public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org, nrb@linux.ibm.com
Cc: thuth@redhat.com, imbrenda@linux.ibm.com
Subject: [kvm-unit-tests PATCH 8/8] s390x: uv-host: Fence access checks when UV debug is enabled
Date: Thu, 23 Mar 2023 10:39:13 +0000	[thread overview]
Message-ID: <20230323103913.40720-9-frankja@linux.ibm.com> (raw)
In-Reply-To: <20230323103913.40720-1-frankja@linux.ibm.com>

The debug print directly accesses the UV header which will result in a
second accesses exception which will abort the test. Let's fence the
access tests instead.

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
 s390x/uv-host.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/s390x/uv-host.c b/s390x/uv-host.c
index b23d51c9..1f73034f 100644
--- a/s390x/uv-host.c
+++ b/s390x/uv-host.c
@@ -164,6 +164,15 @@ static void test_access(void)
 
 	report_prefix_push("access");
 
+	/*
+	 * If debug is enabled info from the uv header is printed
+	 * which would lead to a second exception and a test abort.
+	 */
+	if (UVC_ERR_DEBUG) {
+		report_skip("Debug doesn't work with access tests");
+		goto out;
+	}
+
 	report_prefix_push("non-crossing");
 	protect_page(uvcb, PAGE_ENTRY_I);
 	for (i = 0; cmds[i].name; i++) {
@@ -196,6 +205,7 @@ static void test_access(void)
 	uvcb += 1;
 	unprotect_page(uvcb, PAGE_ENTRY_I);
 
+out:
 	free_pages(pages);
 	report_prefix_pop();
 }
-- 
2.34.1


  parent reply	other threads:[~2023-03-23 10:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23 10:39 [kvm-unit-tests PATCH 0/8] s390x: uv-host: Fixups and extensions part 1 Janosch Frank
2023-03-23 10:39 ` [kvm-unit-tests PATCH 1/8] s390x: uv-host: Fix UV init test memory allocation Janosch Frank
2023-03-23 12:29   ` Nico Boehr
2023-03-23 10:39 ` [kvm-unit-tests PATCH 2/8] s390x: uv-host: Check for sufficient amount of memory Janosch Frank
2023-03-23 12:31   ` Nico Boehr
2023-03-23 10:39 ` [kvm-unit-tests PATCH 3/8] s390x: Add PV tests to unittests.cfg Janosch Frank
2023-03-23 10:39 ` [kvm-unit-tests PATCH 4/8] s390x: uv-host: Beautify code Janosch Frank
2023-03-23 12:52   ` Nico Boehr
2023-03-23 10:39 ` [kvm-unit-tests PATCH 5/8] s390x: uv-host: Add cpu number check Janosch Frank
2023-03-23 12:55   ` Nico Boehr
2023-03-23 10:39 ` [kvm-unit-tests PATCH 6/8] s390x: uv-host: Fix create guest variable storage prefix check Janosch Frank
2023-03-23 13:01   ` Nico Boehr
2023-03-23 10:39 ` [kvm-unit-tests PATCH 7/8] s390x: uv-host: Properly handle config creation errors Janosch Frank
2023-03-23 13:19   ` Nico Boehr
2023-03-23 14:02     ` Janosch Frank
2023-03-23 10:39 ` Janosch Frank [this message]
2023-03-23 13:21   ` [kvm-unit-tests PATCH 8/8] s390x: uv-host: Fence access checks when UV debug is enabled Nico Boehr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230323103913.40720-9-frankja@linux.ibm.com \
    --to=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=nrb@linux.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox