From: Binbin Wu <binbin.wu@linux.intel.com>
To: kvm@vger.kernel.org
Cc: seanjc@google.com, pbonzini@redhat.com, chao.gao@intel.com,
robert.hu@linux.intel.com, binbin.wu@linux.intel.com
Subject: [PATCH v5 4/4] x86: Add test case for INVVPID with LAM
Date: Tue, 30 May 2023 10:43:56 +0800 [thread overview]
Message-ID: <20230530024356.24870-5-binbin.wu@linux.intel.com> (raw)
In-Reply-To: <20230530024356.24870-1-binbin.wu@linux.intel.com>
LAM applies to the linear address of INVVPID operand, however,
it doesn't apply to the linear address in the INVVPID descriptor.
The added cases use tagged operand or tagged target invalidation
address to make sure the behaviors are expected when LAM is on.
Also, INVVPID case using tagged operand can be used as the common
test cases for VMX instruction VMExits.
Signed-off-by: Binbin Wu <binbin.wu@linux.intel.com>
---
x86/vmx_tests.c | 46 +++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 45 insertions(+), 1 deletion(-)
diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
index 217befe..3f3f203 100644
--- a/x86/vmx_tests.c
+++ b/x86/vmx_tests.c
@@ -3225,6 +3225,48 @@ static void invvpid_test_not_in_vmx_operation(void)
TEST_ASSERT(!vmx_on());
}
+/* LAM applies to the target address inside the descriptor of invvpid */
+static void invvpid_test_lam(void)
+{
+ void *vaddr;
+ struct invvpid_operand *operand;
+ u64 lam_mask = LAM48_MASK;
+ bool fault;
+
+ if (!this_cpu_has(X86_FEATURE_LAM)) {
+ report_skip("LAM is not supported, skip INVVPID with LAM");
+ return;
+ }
+ write_cr4_safe(read_cr4() | X86_CR4_LAM_SUP);
+
+ if (this_cpu_has(X86_FEATURE_LA57) && read_cr4() & X86_CR4_LA57)
+ lam_mask = LAM57_MASK;
+
+ vaddr = alloc_vpage();
+ install_page(current_page_table(), virt_to_phys(alloc_page()), vaddr);
+ /*
+ * Since the stack memory address in KUT doesn't follow kernel address
+ * space partition rule, reuse the memory address for descriptor and
+ * the target address in the descriptor of invvpid.
+ */
+ operand = (struct invvpid_operand *)vaddr;
+ operand->vpid = 0xffff;
+ operand->gla = (u64)vaddr;
+ operand = (struct invvpid_operand *)set_la_non_canonical((u64)operand,
+ lam_mask);
+ fault = test_for_exception(GP_VECTOR, ds_invvpid, operand);
+ report(!fault, "INVVPID (LAM on): tagged operand");
+
+ /*
+ * LAM doesn't apply to the address inside the descriptor, expected
+ * failure and VMXERR_INVALID_OPERAND_TO_INVEPT_INVVPID set in
+ * VMX_INST_ERROR.
+ */
+ try_invvpid(INVVPID_ADDR, 0xffff, NONCANONICAL);
+
+ write_cr4_safe(read_cr4() & ~X86_CR4_LAM_SUP);
+}
+
/*
* This does not test real-address mode, virtual-8086 mode, protected mode,
* or CPL > 0.
@@ -3274,8 +3316,10 @@ static void invvpid_test(void)
/*
* The gla operand is only validated for single-address INVVPID.
*/
- if (types & (1u << INVVPID_ADDR))
+ if (types & (1u << INVVPID_ADDR)) {
try_invvpid(INVVPID_ADDR, 0xffff, NONCANONICAL);
+ invvpid_test_lam();
+ }
invvpid_test_gp();
invvpid_test_ss();
--
2.25.1
next prev parent reply other threads:[~2023-05-30 2:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 2:43 [PATCH v5 0/4] x86: Add test cases for LAM Binbin Wu
2023-05-30 2:43 ` [PATCH v5 1/4] x86: Allow setting of CR3 LAM bits if LAM supported Binbin Wu
2023-05-30 2:43 ` [PATCH v5 2/4] x86: Add test case for LAM_SUP Binbin Wu
2023-05-30 2:43 ` [PATCH v5 3/4] x86: Add test cases for LAM_{U48,U57} Binbin Wu
2023-05-30 2:43 ` Binbin Wu [this message]
2023-06-05 13:22 ` [PATCH v5 4/4] x86: Add test case for INVVPID with LAM Chao Gao
2023-06-06 5:47 ` Binbin Wu
2023-06-06 7:02 ` Chao Gao
2023-06-06 7:08 ` Binbin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230530024356.24870-5-binbin.wu@linux.intel.com \
--to=binbin.wu@linux.intel.com \
--cc=chao.gao@intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=robert.hu@linux.intel.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox