public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Nico Boehr <nrb@linux.ibm.com>
To: frankja@linux.ibm.com, imbrenda@linux.ibm.com, thuth@redhat.com,
	pbonzini@redhat.com, andrew.jones@linux.dev, david@redhat.com
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: [kvm-unit-tests PATCH v1] runtime: don't run pv-host tests when gen-se-header is unavailable
Date: Wed, 31 May 2023 12:32:27 +0200	[thread overview]
Message-ID: <20230531103227.1385324-1-nrb@linux.ibm.com> (raw)

When the gen-se-header tool is not given as an argument to configure,
all tests which act as a PV host will not be built by the makefiles.

run_tests.sh will fail when a test binary is missing. This means
when we add the pv-host tests to unittest.cfg we will have FAILs when
gen-se-header is missing.

Since it is desirable to have the tests in unittest.cfg, add a new group
pv-host which designates tests that act as a PV host. These will only
run if the gen-se-header tool is available.

The pv-host group is currently not used, but will be with Janoschs
series "s390x: Add PV SIE intercepts and ipl tests" here:
https://lore.kernel.org/all/20230502115931.86280-1-frankja@linux.ibm.com/

Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
---
 scripts/runtime.bash | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/scripts/runtime.bash b/scripts/runtime.bash
index 07b62b0e1fe7..486dbeda8179 100644
--- a/scripts/runtime.bash
+++ b/scripts/runtime.bash
@@ -98,6 +98,11 @@ function run()
         return
     fi
 
+    if [ -z "$GEN_SE_HEADER" ] && find_word "pv-host" "$groups"; then
+        print_result "SKIP" $testname "" "no gen-se-header available for pv-host test"
+        return
+    fi
+
     if [ -z "$only_group" ] && find_word nodefault "$groups" &&
             skip_nodefault; then
         print_result "SKIP" $testname "" "test marked as manual run only"
-- 
2.39.1


             reply	other threads:[~2023-05-31 10:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-31 10:32 Nico Boehr [this message]
2023-05-31 11:17 ` [kvm-unit-tests PATCH v1] runtime: don't run pv-host tests when gen-se-header is unavailable Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230531103227.1385324-1-nrb@linux.ibm.com \
    --to=nrb@linux.ibm.com \
    --cc=andrew.jones@linux.dev \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox