From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F9CFC7EE2E for ; Fri, 9 Jun 2023 07:18:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236735AbjFIHSQ (ORCPT ); Fri, 9 Jun 2023 03:18:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbjFIHSO (ORCPT ); Fri, 9 Jun 2023 03:18:14 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8450359A for ; Fri, 9 Jun 2023 00:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686295048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=15kZRnaZwPiIUtkudYdawd69yNtpyzsjo2sikqV4oqc=; b=jEP52qohZQJT2y88ha6pyPF0QfpTiA6ClaCQZDYmgsjMwDtPir+ig5XYKv4Mtmm0Q5GIzq E8fmFT/ribzFQ58phO8V+WHuv0j6GusZv2aLJdctToIloPb0Om9Kmbh0aOuIxDS4aynQHt Fba19R6OaphkUqksXmS+Rp3B7TTrs+g= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-288-vkLlELCnOKiGvXwtlalU8w-1; Fri, 09 Jun 2023 03:17:26 -0400 X-MC-Unique: vkLlELCnOKiGvXwtlalU8w-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f5df65f9f4so7053545e9.2 for ; Fri, 09 Jun 2023 00:17:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686295045; x=1688887045; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=15kZRnaZwPiIUtkudYdawd69yNtpyzsjo2sikqV4oqc=; b=RoZoeTBP4X4volWwA8mHx9tH+sq7VAzfaQ2DMM2AU4nzgjqB0Fl0jyLzlrvhuPm9AP ZijHbzb6ATeu47Fzoqco34QeX7SIKxSI/Wg67seq7t8Fg/9KXYdzTV4kgVegrlQK8aov majj/nV+f9PoLH5OYD254ioX0ofPY5mPcFX+wikuwICxxeVMlZ5Eca+xbKlUIGFeIvIb 6zo/GYoOYNBSLn7+NxYYWvzh/nktF1M5fEF/7yRprl2+C5D6bYo8ITHoJPMTiLBolGDI yCkQ1k3jEH3+BiCmP50bga7nz/7DzkG2Cr5CqpfL3dNPMfkUf7eWxZVRn9H9deahH/2S 0k4w== X-Gm-Message-State: AC+VfDxnv8XvxD3k9FL0OeOLU4PfjA9thboFHNwf/0SnZ9Mt6Bb3CiF3 RTMOopnwH5+shOmAXtNT6dKP2hR6tc2jpPvuFu2UgAinrT5VhmZ1f2RBjJWIrRojM2u5P5rr/F4 loFtvcLST3R/C X-Received: by 2002:a05:600c:c2:b0:3f7:30c0:c6a with SMTP id u2-20020a05600c00c200b003f730c00c6amr433283wmm.25.1686295045441; Fri, 09 Jun 2023 00:17:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7waRKCvgqgJoAjOYyIenyGhdYJn4/2vpRsAbVkjBZW18/rDXsC3rXgUmARtFQATJ5s/wzvLA== X-Received: by 2002:a05:600c:c2:b0:3f7:30c0:c6a with SMTP id u2-20020a05600c00c200b003f730c00c6amr433267wmm.25.1686295045075; Fri, 09 Jun 2023 00:17:25 -0700 (PDT) Received: from redhat.com ([2.55.4.169]) by smtp.gmail.com with ESMTPSA id k15-20020a7bc40f000000b003f7f1b3aff1sm1711774wmi.26.2023.06.09.00.17.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jun 2023 00:17:24 -0700 (PDT) Date: Fri, 9 Jun 2023 03:17:20 -0400 From: "Michael S. Tsirkin" To: Jason Wang Cc: Stefano Garzarella , Shannon Nelson , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, Eugenio =?iso-8859-1?Q?P=E9rez?= , Tiwei Bie , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vhost-vdpa: filter VIRTIO_F_RING_PACKED feature Message-ID: <20230609031610-mutt-send-email-mst@kernel.org> References: <20230607054246-mutt-send-email-mst@kernel.org> <20230608020111-mutt-send-email-mst@kernel.org> <5giudxjp6siucr4l3i4tggrh2dpqiqhhihmdd34w3mq2pm5dlo@mrqpbwckpxai> <20230608102259-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Jun 09, 2023 at 10:16:50AM +0800, Jason Wang wrote: > On Thu, Jun 8, 2023 at 10:23 PM Michael S. Tsirkin wrote: > > > > On Thu, Jun 08, 2023 at 05:29:58PM +0800, Jason Wang wrote: > > > On Thu, Jun 8, 2023 at 5:21 PM Stefano Garzarella wrote: > > > > > > > > On Thu, Jun 08, 2023 at 05:00:00PM +0800, Jason Wang wrote: > > > > >On Thu, Jun 8, 2023 at 4:00 PM Stefano Garzarella wrote: > > > > >> > > > > >> On Thu, Jun 08, 2023 at 03:46:00PM +0800, Jason Wang wrote: > > > > >> > > > > >> [...] > > > > >> > > > > >> >> > > > > I have a question though, what if down the road there > > > > >> >> > > > > is a new feature that needs more changes? It will be > > > > >> >> > > > > broken too just like PACKED no? > > > > >> >> > > > > Shouldn't vdpa have an allowlist of features it knows how > > > > >> >> > > > > to support? > > > > >> >> > > > > > > > >> >> > > > It looks like we had it, but we took it out (by the way, we were > > > > >> >> > > > enabling packed even though we didn't support it): > > > > >> >> > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6234f80574d7569444d8718355fa2838e92b158b > > > > >> >> > > > > > > > >> >> > > > The only problem I see is that for each new feature we have to modify > > > > >> >> > > > the kernel. > > > > >> >> > > > Could we have new features that don't require handling by vhost-vdpa? > > > > >> >> > > > > > > > >> >> > > > Thanks, > > > > >> >> > > > Stefano > > > > >> >> > > > > > > >> >> > > Jason what do you say to reverting this? > > > > >> >> > > > > > >> >> > I may miss something but I don't see any problem with vDPA core. > > > > >> >> > > > > > >> >> > It's the duty of the parents to advertise the features it has. For example, > > > > >> >> > > > > > >> >> > 1) If some kernel version that is packed is not supported via > > > > >> >> > set_vq_state, parents should not advertise PACKED features in this > > > > >> >> > case. > > > > >> >> > 2) If the kernel has support packed set_vq_state(), but it's emulated > > > > >> >> > cvq doesn't support, parents should not advertise PACKED as well > > > > >> >> > > > > > >> >> > If a parent violates the above 2, it looks like a bug of the parents. > > > > >> >> > > > > > >> >> > Thanks > > > > >> >> > > > > >> >> Yes but what about vhost_vdpa? Talking about that not the core. > > > > >> > > > > > >> >Not sure it's a good idea to workaround parent bugs via vhost-vDPA. > > > > >> > > > > >> Sorry, I'm getting lost... > > > > >> We were talking about the fact that vhost-vdpa doesn't handle > > > > >> SET_VRING_BASE/GET_VRING_BASE ioctls well for packed virtqueue before > > > > >> that series [1], no? > > > > >> > > > > >> The parents seem okay, but maybe I missed a few things. > > > > >> > > > > >> [1] https://lore.kernel.org/virtualization/20230424225031.18947-1-shannon.nelson@amd.com/ > > > > > > > > > >Yes, more below. > > > > > > > > > >> > > > > >> > > > > > >> >> Should that not have a whitelist of features > > > > >> >> since it interprets ioctls differently depending on this? > > > > >> > > > > > >> >If there's a bug, it might only matter the following setup: > > > > >> > > > > > >> >SET_VRING_BASE/GET_VRING_BASE + VDUSE. > > > > >> > > > > > >> >This seems to be broken since VDUSE was introduced. If we really want > > > > >> >to backport something, it could be a fix to filter out PACKED in > > > > >> >VDUSE? > > > > >> > > > > >> mmm it doesn't seem to be a problem in VDUSE, but in vhost-vdpa. > > > > >> I think VDUSE works fine with packed virtqueue using virtio-vdpa > > > > >> (I haven't tried), so why should we filter PACKED in VDUSE? > > > > > > > > > >I don't think we need any filtering since: > > > > > > > > > >PACKED features has been advertised to userspace via uAPI since > > > > >6234f80574d7569444d8718355fa2838e92b158b. Once we relax in uAPI, it > > > > >would be very hard to restrict it again. For the userspace that tries > > > > >to negotiate PACKED: > > > > > > > > > >1) if it doesn't use SET_VRING_BASE/GET_VRING_BASE, everything works well > > > > >2) if it uses SET_VRING_BASE/GET_VRING_BASE. it might fail or break silently > > > > > > > > > >If we backport the fixes to -stable, we may break the application at > > > > >least in the case 1). > > > > > > > > Okay, I see now, thanks for the details! > > > > > > > > Maybe instead of "break silently", we can return an explicit error for > > > > SET_VRING_BASE/GET_VRING_BASE in stable branches. > > > > But if there are not many cases, we can leave it like that. > > > > > > A second thought, if we need to do something for stable. is it better > > > if we just backport Shannon's series to stable? > > > > > > > > > > > I was just concerned about how does the user space understand that it > > > > can use SET_VRING_BASE/GET_VRING_BASE for PACKED virtqueues in a given > > > > kernel or not. > > > > > > My understanding is that if packed is advertised, the application > > > should assume SET/GET_VRING_BASE work. > > > > > > Thanks > > > > > > Let me ask you this. This is a bugfix yes? > > Not sure since it may break existing user space applications which > make it hard to be backported to -stable. Sorry, I was actually referring to vhost_vdpa: support PACKED when setting-getting vring_base and friends. These are bugfixes yes? What is the appropriate Fixes tag? > Before the fix, PACKED might work if SET/GET_VRING_BASE is not used. > After the fix, PACKED won't work at all. > > Thanks > > What is the appropriate Fixes > > tag? > > > > > > > > > > Thanks, > > > > Stefano > > > > > >