public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Oliver Upton <oliver.upton@linux.dev>
To: kvmarm@lists.linux.dev
Cc: kvm@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
	James Morse <james.morse@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Zenghui Yu <yuzenghui@huawei.com>, Will Deacon <will@kernel.org>,
	Julien Thierry <julien.thierry.kdev@gmail.com>,
	Salil Mehta <salil.mehta@huawei.com>,
	Oliver Upton <oliver.upton@linux.dev>
Subject: [PATCH v2 20/20] aarch64: smccc: Start sending PSCI to userspace
Date: Tue, 20 Jun 2023 11:35:32 -0500	[thread overview]
Message-ID: <20230620163532.2689112-1-oliver.upton@linux.dev> (raw)
In-Reply-To: <20230620163353.2688567-1-oliver.upton@linux.dev>

kvmtool now has a PSCI implementation that complies with v1.0 of the
specification. Use the SMCCC filter to start sending these calls out to
userspace for further handling. While at it, shut the door on the
legacy, KVM-specific v0.1 functions.

Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
---
 arm/aarch64/include/kvm/kvm-config-arch.h |  6 +++-
 arm/aarch64/smccc.c                       | 37 +++++++++++++++++++++++
 arm/include/arm-common/kvm-config-arch.h  |  1 +
 3 files changed, 43 insertions(+), 1 deletion(-)

diff --git a/arm/aarch64/include/kvm/kvm-config-arch.h b/arm/aarch64/include/kvm/kvm-config-arch.h
index eae8080..1c40bba 100644
--- a/arm/aarch64/include/kvm/kvm-config-arch.h
+++ b/arm/aarch64/include/kvm/kvm-config-arch.h
@@ -19,7 +19,11 @@ int vcpu_affinity_parser(const struct option *opt, const char *arg, int unset);
 			"Specify random seed for Kernel Address Space "	\
 			"Layout Randomization (KASLR)"),		\
 	OPT_BOOLEAN('\0', "no-pvtime", &(cfg)->no_pvtime, "Disable"	\
-			" stolen time"),
+			" stolen time"),				\
+	OPT_BOOLEAN('\0', "in-kernel-smccc", &(cfg)->in_kernel_smccc,	\
+			"Disable userspace handling of SMCCC, instead"	\
+			" relying on the in-kernel implementation"),
+
 #include "arm-common/kvm-config-arch.h"
 
 #endif /* KVM__KVM_CONFIG_ARCH_H */
diff --git a/arm/aarch64/smccc.c b/arm/aarch64/smccc.c
index ef986d8..62d826b 100644
--- a/arm/aarch64/smccc.c
+++ b/arm/aarch64/smccc.c
@@ -38,7 +38,44 @@ out:
 	return true;
 }
 
+static struct kvm_smccc_filter filter_ranges[] = {
+	{
+		.base		= KVM_PSCI_FN_BASE,
+		.nr_functions	= 4,
+		.action		= KVM_SMCCC_FILTER_DENY,
+	},
+	{
+		.base		= PSCI_0_2_FN_BASE,
+		.nr_functions	= 0x20,
+		.action		= KVM_SMCCC_FILTER_FWD_TO_USER,
+	},
+	{
+		.base		= PSCI_0_2_FN64_BASE,
+		.nr_functions	= 0x20,
+		.action		= KVM_SMCCC_FILTER_FWD_TO_USER,
+	},
+};
+
 void kvm__setup_smccc(struct kvm *kvm)
 {
+	struct kvm_device_attr attr = {
+		.group	= KVM_ARM_VM_SMCCC_CTRL,
+		.attr	= KVM_ARM_VM_SMCCC_FILTER,
+	};
+	unsigned int i;
 
+	if (kvm->cfg.arch.in_kernel_smccc)
+		return;
+
+	if (ioctl(kvm->vm_fd, KVM_HAS_DEVICE_ATTR, &attr)) {
+		pr_debug("KVM SMCCC filter not supported");
+		return;
+	}
+
+	for (i = 0; i < ARRAY_SIZE(filter_ranges); i++) {
+		attr.addr = (u64)&filter_ranges[i];
+
+		if (ioctl(kvm->vm_fd, KVM_SET_DEVICE_ATTR, &attr))
+			die_perror("KVM_SET_DEVICE_ATTR failed");
+	}
 }
diff --git a/arm/include/arm-common/kvm-config-arch.h b/arm/include/arm-common/kvm-config-arch.h
index 23a7486..223b5a9 100644
--- a/arm/include/arm-common/kvm-config-arch.h
+++ b/arm/include/arm-common/kvm-config-arch.h
@@ -14,6 +14,7 @@ struct kvm_config_arch {
 	enum irqchip_type irqchip;
 	u64		fw_addr;
 	bool no_pvtime;
+	bool		in_kernel_smccc;
 };
 
 int irqchip_parser(const struct option *opt, const char *arg, int unset);
-- 
2.41.0.162.gfafddb0af9-goog


      parent reply	other threads:[~2023-06-20 16:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20 16:33 [PATCH v2 00/20] arm64: Handle PSCI calls in userspace Oliver Upton
2023-06-20 16:33 ` [PATCH v2 01/20] update_headers: Use a list for arch-generic headers Oliver Upton
2023-06-20 16:33 ` [PATCH v2 02/20] update_headers: Add missing entries to list of headers to copy Oliver Upton
2023-06-20 16:33 ` [PATCH v2 03/20] Copy 64-bit alignment attrtibutes from Linux 6.4-rc1 Oliver Upton
2023-06-20 16:33 ` [PATCH v2 04/20] Update headers with " Oliver Upton
2023-06-20 16:33 ` [PATCH v2 05/20] Import arm-smccc.h from " Oliver Upton
2023-06-20 16:33 ` [PATCH v2 06/20] aarch64: Copy cputype.h " Oliver Upton
2023-06-20 16:33 ` [PATCH v2 07/20] arm: Stash kvm_vcpu_init for later use Oliver Upton
2023-06-20 16:33 ` [PATCH v2 08/20] arm: Use KVM_SET_MP_STATE ioctl to power off non-boot vCPUs Oliver Upton
2023-06-20 16:33 ` [PATCH v2 09/20] aarch64: Expose ARM64_CORE_REG() for general use Oliver Upton
2023-06-20 16:33 ` [PATCH v2 10/20] arm: Generalize execution state specific VM initialization Oliver Upton
2023-06-20 16:33 ` [PATCH v2 11/20] Add helpers to pause the VM from vCPU thread Oliver Upton
2023-06-20 16:33 ` [PATCH v2 12/20] aarch64: Add support for finding vCPU for given MPIDR Oliver Upton
2023-06-20 16:33 ` [PATCH v2 13/20] aarch64: Add skeleton implementation for PSCI Oliver Upton
2023-06-20 16:33 ` [PATCH v2 14/20] aarch64: psci: Implement CPU_SUSPEND Oliver Upton
2023-06-20 16:33 ` [PATCH v2 15/20] aarch64: psci: Implement CPU_OFF Oliver Upton
2023-06-20 16:33 ` [PATCH v2 16/20] aarch64: psci: Implement CPU_ON Oliver Upton
2023-06-20 16:33 ` [PATCH v2 17/20] aarch64: psci: Implement AFFINITY_INFO Oliver Upton
2023-06-20 16:33 ` [PATCH v2 18/20] aarch64: psci: Implement MIGRATE_INFO_TYPE Oliver Upton
2023-06-20 16:33 ` [PATCH v2 19/20] aarch64: psci: Implement SYSTEM_{OFF,RESET} Oliver Upton
2023-06-20 16:35 ` Oliver Upton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230620163532.2689112-1-oliver.upton@linux.dev \
    --to=oliver.upton@linux.dev \
    --cc=james.morse@arm.com \
    --cc=julien.thierry.kdev@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=maz@kernel.org \
    --cc=salil.mehta@huawei.com \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox