Re: [kvm-unit-tests PATCH v3 2/6] lib/stack: print base addresses on relocation setups

Nadav Amit
2023-07-01T17:18:40Z

> On Jul 1, 2023, at 4:34 AM, Andrew Jones <andrew.jones@linux.dev> wrote:
>
> !! External Email
>
> On Wed, Jun 28, 2023 at 12:13:51AM +0000, Nadav Amit wrote:
> ...
>> diff --git a/powerpc/Makefile.common b/powerpc/Makefile.common
>> index 8ce0034..c2e976e 100644
>> --- a/powerpc/Makefile.common
>> +++ b/powerpc/Makefile.common
>> @@ -24,6 +24,7 @@ CFLAGS += -ffreestanding
>> CFLAGS += -O2 -msoft-float -mno-altivec $(mabi_no_altivec)
>> CFLAGS += -I $(SRCDIR)/lib -I $(SRCDIR)/lib/libfdt -I lib
>> CFLAGS += -Wa,-mregnames
>> +CFLAGS += -DCONFIG_RELOC
>>
>
> I dropped this change. powerpc doesn't define _text and _etext.
> I'll leave it to the ppc people to decide if they want this and
> want to add _text and _etext to get it.

Thanks for taking care of it. Sorry for not noticing. I am always
not inclined to change arch’s that I don’t use.