From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D18CBEB64DC for ; Sat, 1 Jul 2023 14:28:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230192AbjGAO2u (ORCPT ); Sat, 1 Jul 2023 10:28:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229753AbjGAO2t (ORCPT ); Sat, 1 Jul 2023 10:28:49 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D66AC35AF for ; Sat, 1 Jul 2023 07:28:47 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-4fb761efa7aso4674820e87.0 for ; Sat, 01 Jul 2023 07:28:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1688221726; x=1690813726; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Nw6L3iecsaCHUkBPU5RXg0XPBqr03epBdZqP9RT9erM=; b=SEjhRB1Z/veXvWxjUBHdLcwTje8hQss7D2GARjcPTW6LyYt9be7tMUY0+aJv5FX8d6 WN/IafFrpna99BKEss4ZEakuEqvPrr6jxvYicXyxhd9gki78+V6ZtrpXO7KDyY0LdunP wF+BIzAGDimhr5pUbfOSVBCdwpO2gAJq+H9oMydEoOX4/yBqliuqlSGq7I6UPlTkDlqc Ie8Ghz4fDCBz8V386sK5acwN5hWNX867hbR7NDNaZzi79fiWs1LvQaSE3LA2SeplH7AO msFZOPYU8Lpc/KeJfHlTxl1wDJ5tIMB/r0Hr/41wnEKrCOw+bWh9f8QNwaIhh3zufJYc Z3Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688221726; x=1690813726; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Nw6L3iecsaCHUkBPU5RXg0XPBqr03epBdZqP9RT9erM=; b=M+/34Ke6FdC48hxPv1dp70E/H9KCOJ4fh5n7tq4UJDZoERITSKjGF4yc1ywBpW23Pv Qhlm5qAe4ecBuXhVr8bvMQmmXYtdIjmq4/a575o5i6oDrYs0JADJ01Nsg8NcGYKeP9HF dJ7c9AtCsAqft8O8k1EA+tLE62zEXfXFwCwQXzw6oVJoou+8fXdRmieiM8j86iPsak5H XRm3F/WLNFPHNLlfht1oIBEQWQiAFGaqjI6NQ1H1hUoJdRX55H5LIS+2YXDGtAmK6T3V b0qmjzyNd9BeLIVGznsGWhOR7+4p1HCmKIomNqBL7bZkysiHBJ7lon3AtWWoWYbUseoY lc4A== X-Gm-Message-State: ABy/qLYy4hIOnLx5djLekfU47uDajK+logfINpCYQX7afNsvBinLEMG5 mzs2SIaff5rFf9o6lrMA8mNu7A== X-Google-Smtp-Source: APBJJlFs2bVJyhr2R8sltfd2/9wcvYSRVXsl+ohedKMBwI0k0S5K4jvnxW5ud0AbpO+XIPriRJi6lg== X-Received: by 2002:ac2:4db5:0:b0:4f8:6a29:b59b with SMTP id h21-20020ac24db5000000b004f86a29b59bmr3767983lfe.64.1688221725981; Sat, 01 Jul 2023 07:28:45 -0700 (PDT) Received: from localhost (cst2-173-16.cust.vodafone.cz. [31.30.173.16]) by smtp.gmail.com with ESMTPSA id z15-20020aa7c64f000000b0051de52f8adesm2357555edr.32.2023.07.01.07.28.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jul 2023 07:28:45 -0700 (PDT) Date: Sat, 1 Jul 2023 16:28:43 +0200 From: Andrew Jones To: Haibo Xu Cc: xiaobo55x@gmail.com, maz@kernel.org, oliver.upton@linux.dev, seanjc@google.com, Paolo Bonzini , Jonathan Corbet , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Shuah Khan , James Morse , Suzuki K Poulose , Zenghui Yu , Ricardo Koller , Vishal Annapurve , Vipin Sharma , David Matlack , Colton Lewis , kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v5 11/13] KVM: selftests: Add skip_set facility to get_reg_list test Message-ID: <20230701-2da2a0ffa7c1ccd3a549acea@orel> References: <0a418f26388e744b6ae2f17639bea08a05643549.1688010022.git.haibo1.xu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a418f26388e744b6ae2f17639bea08a05643549.1688010022.git.haibo1.xu@intel.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Sat, Jul 01, 2023 at 09:42:59PM +0800, Haibo Xu wrote: > Add new skips_set members to vcpu_reg_sublist so as to skip > set operation on some registers. > > Suggested-by: Andrew Jones > Signed-off-by: Haibo Xu > --- > tools/testing/selftests/kvm/get-reg-list.c | 20 +++++++++++++------ > .../selftests/kvm/include/kvm_util_base.h | 2 ++ > 2 files changed, 16 insertions(+), 6 deletions(-) > > diff --git a/tools/testing/selftests/kvm/get-reg-list.c b/tools/testing/selftests/kvm/get-reg-list.c > index 74fb6f6fdd09..1a32a900aeea 100644 > --- a/tools/testing/selftests/kvm/get-reg-list.c > +++ b/tools/testing/selftests/kvm/get-reg-list.c > @@ -157,6 +157,7 @@ static void run_test(struct vcpu_reg_list *c) > { > int new_regs = 0, missing_regs = 0, i, n; > int failed_get = 0, failed_set = 0, failed_reject = 0; > + int skipped_set = 0; > struct kvm_vcpu *vcpu; > struct kvm_vm *vm; > struct vcpu_reg_sublist *s; > @@ -210,7 +211,7 @@ static void run_test(struct vcpu_reg_list *c) > .id = reg_list->reg[i], > .addr = (__u64)&addr, > }; > - bool reject_reg = false; > + bool reject_reg = false, skip_reg = false; > int ret; > > ret = __vcpu_get_reg(vcpu, reg_list->reg[i], &addr); > @@ -221,8 +222,8 @@ static void run_test(struct vcpu_reg_list *c) > ++failed_get; > } > > - /* rejects_set registers are rejected after KVM_ARM_VCPU_FINALIZE */ > for_each_sublist(c, s) { > + /* rejects_set registers are rejected for set operation */ > if (s->rejects_set && find_reg(s->rejects_set, s->rejects_set_n, reg.id)) { > reject_reg = true; > ret = __vcpu_ioctl(vcpu, KVM_SET_ONE_REG, ®); > @@ -234,9 +235,16 @@ static void run_test(struct vcpu_reg_list *c) > } > break; > } > + > + /* skips_set registers are skipped for set operation */ > + if (s->skips_set && find_reg(s->skips_set, s->skips_set_n, reg.id)) { > + skip_reg = true; > + ++skipped_set; > + break; > + } > } > > - if (!reject_reg) { > + if (!reject_reg && !skip_reg) { > ret = __vcpu_ioctl(vcpu, KVM_SET_ONE_REG, ®); > if (ret) { > printf("%s: Failed to set ", config_name(c)); > @@ -281,9 +289,9 @@ static void run_test(struct vcpu_reg_list *c) > } > > TEST_ASSERT(!missing_regs && !failed_get && !failed_set && !failed_reject, > - "%s: There are %d missing registers; " > - "%d registers failed get; %d registers failed set; %d registers failed reject", > - config_name(c), missing_regs, failed_get, failed_set, failed_reject); > + "%s: There are %d missing registers; %d registers failed get; " > + "%d registers failed set; %d registers failed reject; %d registers skipped set", > + config_name(c), missing_regs, failed_get, failed_set, failed_reject, skipped_set); > > pr_info("%s: PASS\n", config_name(c)); > blessed_n = 0; > diff --git a/tools/testing/selftests/kvm/include/kvm_util_base.h b/tools/testing/selftests/kvm/include/kvm_util_base.h > index e4480049000d..67c031fe89a1 100644 > --- a/tools/testing/selftests/kvm/include/kvm_util_base.h > +++ b/tools/testing/selftests/kvm/include/kvm_util_base.h > @@ -134,6 +134,8 @@ struct vcpu_reg_sublist { > __u64 regs_n; > __u64 *rejects_set; > __u64 rejects_set_n; > + __u64 *skips_set; > + __u64 skips_set_n; > }; > > struct vcpu_reg_list { > -- > 2.34.1 > Reviewed-by: Andrew Jones