public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
	thuth@redhat.com, david@redhat.com, nsg@linux.ibm.com,
	nrb@linux.ibm.com
Subject: [kvm-unit-tests PATCH 0/2] s390x: Improve console handling
Date: Fri,  7 Jul 2023 14:54:08 +0000	[thread overview]
Message-ID: <20230707145410.1679-1-frankja@linux.ibm.com> (raw)

Console IO is and has been in a state of "works for me". I don't think
that will change soon since there's no need for a proper console
driver when all we want is the ability to print or read a line at a
time.

However since input is only supported on the ASCII console I was
forced to use it on the HMC. The HMC generally does not add a \r on a
\n so each line doesn't necessarily start at column 0. It's time to
finally fix that.

Also, since there are environments that only provide the line-mode
console it's time to add line-mode input to properly support them.

rfc -> v1:
	- Switched to \r\n from \n\r
	- Removed console clear
	- Added truncation logic to maintain 2k limit

Janosch Frank (2):
  lib: s390x: sclp: Add carriage return to line feed
  lib: s390x: sclp: Add line mode input handling

 lib/s390x/sclp-console.c | 193 +++++++++++++++++++++++++++++++++++----
 lib/s390x/sclp.h         |  26 +++++-
 2 files changed, 198 insertions(+), 21 deletions(-)

-- 
2.34.1


             reply	other threads:[~2023-07-07 14:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-07 14:54 Janosch Frank [this message]
2023-07-07 14:54 ` [kvm-unit-tests PATCH 1/2] lib: s390x: sclp: Add carriage return to line feed Janosch Frank
2023-07-07 14:54 ` [kvm-unit-tests PATCH 2/2] lib: s390x: sclp: Add line mode input handling Janosch Frank
2023-07-10  9:33   ` Nico Boehr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230707145410.1679-1-frankja@linux.ibm.com \
    --to=frankja@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=nrb@linux.ibm.com \
    --cc=nsg@linux.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox