public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Nico Boehr <nrb@linux.ibm.com>
To: frankja@linux.ibm.com, imbrenda@linux.ibm.com, thuth@redhat.com
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: [kvm-unit-tests PATCH v5 3/6] s390x: sie: switch to home space mode before entering SIE
Date: Wed, 12 Jul 2023 13:41:46 +0200	[thread overview]
Message-ID: <20230712114149.1291580-4-nrb@linux.ibm.com> (raw)
In-Reply-To: <20230712114149.1291580-1-nrb@linux.ibm.com>

This is to prepare for running guests without MSO/MSL, which is
currently not possible.

We already have code in sie64a to setup a guest primary ASCE before
entering SIE, so we can in theory switch to the page tables which
translate gpa to hpa.

But the host is running in primary space mode already, so changing the
primary ASCE before entering SIE will also affect the host's code and
data.

To make this switch useful, the host should run in a different address
space mode. Hence, set up and change to home address space mode before
installing the guest ASCE.

The home space ASCE is just copied over from the primary space ASCE, so
no functional change is intended, also for tests that want to use
MSO/MSL. If a test intends to use a different primary space ASCE, it can
now just set the guest.asce in the save_area.

Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
---
 lib/s390x/asm/arch_def.h |  1 +
 lib/s390x/sie.c          | 18 ++++++++++++++++++
 2 files changed, 19 insertions(+)

diff --git a/lib/s390x/asm/arch_def.h b/lib/s390x/asm/arch_def.h
index 53279572a9ee..65e1cf58c7e7 100644
--- a/lib/s390x/asm/arch_def.h
+++ b/lib/s390x/asm/arch_def.h
@@ -91,6 +91,7 @@ struct cpu {
 #define AS_HOME				3
 
 #define PSW_MASK_DAT			0x0400000000000000UL
+#define PSW_MASK_HOME			0x0000C00000000000UL
 #define PSW_MASK_IO			0x0200000000000000UL
 #define PSW_MASK_EXT			0x0100000000000000UL
 #define PSW_MASK_KEY			0x00F0000000000000UL
diff --git a/lib/s390x/sie.c b/lib/s390x/sie.c
index 9241b4b4a512..ffa8ec91a423 100644
--- a/lib/s390x/sie.c
+++ b/lib/s390x/sie.c
@@ -46,6 +46,8 @@ void sie_handle_validity(struct vm *vm)
 
 void sie(struct vm *vm)
 {
+	uint64_t old_cr13;
+
 	if (vm->sblk->sdf == 2)
 		memcpy(vm->sblk->pv_grregs, vm->save_area.guest.grs,
 		       sizeof(vm->save_area.guest.grs));
@@ -53,6 +55,16 @@ void sie(struct vm *vm)
 	/* Reset icptcode so we don't trip over it below */
 	vm->sblk->icptcode = 0;
 
+	/* set up home address space to match primary space */
+	old_cr13 = stctg(13);
+	lctlg(13, stctg(1));
+
+	/* switch to home space so guest tables can be different from host */
+	psw_mask_set_bits(PSW_MASK_HOME);
+
+	/* also handle all interruptions in home space while in SIE */
+	irq_set_dat_mode(IRQ_DAT_ON, AS_HOME);
+
 	while (vm->sblk->icptcode == 0) {
 		sie64a(vm->sblk, &vm->save_area);
 		sie_handle_validity(vm);
@@ -60,6 +72,12 @@ void sie(struct vm *vm)
 	vm->save_area.guest.grs[14] = vm->sblk->gg14;
 	vm->save_area.guest.grs[15] = vm->sblk->gg15;
 
+	irq_set_dat_mode(IRQ_DAT_ON, AS_PRIM);
+	psw_mask_clear_bits(PSW_MASK_HOME);
+
+	/* restore the old CR 13 */
+	lctlg(13, old_cr13);
+
 	if (vm->sblk->sdf == 2)
 		memcpy(vm->save_area.guest.grs, vm->sblk->pv_grregs,
 		       sizeof(vm->save_area.guest.grs));
-- 
2.40.1


  parent reply	other threads:[~2023-07-12 11:42 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-12 11:41 [kvm-unit-tests PATCH v5 0/6] s390x: Add support for running guests without MSO/MSL Nico Boehr
2023-07-12 11:41 ` [kvm-unit-tests PATCH v5 1/6] lib: s390x: introduce bitfield for PSW mask Nico Boehr
2023-07-13  6:56   ` Thomas Huth
2023-07-13  6:57     ` Thomas Huth
2023-07-13  9:25     ` Nico Boehr
2023-07-13  8:20   ` Claudio Imbrenda
2023-07-13  9:35     ` Nico Boehr
2023-07-12 11:41 ` [kvm-unit-tests PATCH v5 2/6] s390x: add function to set DAT mode for all interrupts Nico Boehr
2023-07-13  7:17   ` Thomas Huth
2023-07-13  8:23     ` Claudio Imbrenda
2023-07-13 15:30     ` Nico Boehr
2023-07-14  6:44       ` Thomas Huth
2023-07-14 10:38         ` Nico Boehr
2023-07-13  8:24   ` Claudio Imbrenda
2023-07-13 15:35     ` Nico Boehr
2023-07-12 11:41 ` Nico Boehr [this message]
2023-07-13  7:28   ` [kvm-unit-tests PATCH v5 3/6] s390x: sie: switch to home space mode before entering SIE Thomas Huth
2023-07-13  8:17     ` Claudio Imbrenda
2023-07-13  8:21       ` Thomas Huth
2023-07-14  8:21         ` Nico Boehr
2023-07-14  8:30           ` Thomas Huth
2023-07-14 10:31             ` Nico Boehr
2023-07-12 11:41 ` [kvm-unit-tests PATCH v5 4/6] s390x: lib: don't forward PSW when handling exception in SIE Nico Boehr
2023-07-12 11:41 ` [kvm-unit-tests PATCH v5 5/6] s390x: lib: sie: don't reenter SIE on pgm int Nico Boehr
2023-07-13  7:51   ` Thomas Huth
2023-07-12 11:41 ` [kvm-unit-tests PATCH v5 6/6] s390x: add a test for SIE without MSO/MSL Nico Boehr
2023-07-13  8:29   ` Thomas Huth
2023-07-14  8:35     ` Nico Boehr
2023-07-14  8:40       ` Thomas Huth
2023-07-14 10:39         ` Nico Boehr
2023-07-14 10:52           ` Thomas Huth
2023-08-01  6:51             ` Nico Boehr
2023-08-14 14:59               ` Thomas Huth
2023-08-15 11:30                 ` Janosch Frank
2023-08-15 14:07                   ` Thomas Huth
2023-08-15 14:26                     ` Janosch Frank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230712114149.1291580-4-nrb@linux.ibm.com \
    --to=nrb@linux.ibm.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox