From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Nico Boehr <nrb@linux.ibm.com>,
frankja@linux.ibm.com, kvm@vger.kernel.org,
linux-s390@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v5 3/6] s390x: sie: switch to home space mode before entering SIE
Date: Thu, 13 Jul 2023 10:17:07 +0200 [thread overview]
Message-ID: <20230713101707.1d1da214@p-imbrenda> (raw)
In-Reply-To: <3dbe3094-b796-6b78-a97f-130a82780421@redhat.com>
On Thu, 13 Jul 2023 09:28:19 +0200
Thomas Huth <thuth@redhat.com> wrote:
[...]
> > + irq_set_dat_mode(IRQ_DAT_ON, AS_PRIM);
> > + psw_mask_clear_bits(PSW_MASK_HOME);
> > +
> > + /* restore the old CR 13 */
> > + lctlg(13, old_cr13);
>
> Wouldn't it be better to always switch to HOME address mode directly in our
> startup code already (where we enable DAT)? Switching back and forth every
> time we enter SIE looks confusing to me ... or is there a reason why we
> should continue to run in primary address mode by default and only switch to
> home mode here?
the existing tests are written with the assumption that they are
running in primary mode.
switching back and forth might be confusing, but avoids having to
fix all the tests
>
> Thomas
>
>
next prev parent reply other threads:[~2023-07-13 8:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 11:41 [kvm-unit-tests PATCH v5 0/6] s390x: Add support for running guests without MSO/MSL Nico Boehr
2023-07-12 11:41 ` [kvm-unit-tests PATCH v5 1/6] lib: s390x: introduce bitfield for PSW mask Nico Boehr
2023-07-13 6:56 ` Thomas Huth
2023-07-13 6:57 ` Thomas Huth
2023-07-13 9:25 ` Nico Boehr
2023-07-13 8:20 ` Claudio Imbrenda
2023-07-13 9:35 ` Nico Boehr
2023-07-12 11:41 ` [kvm-unit-tests PATCH v5 2/6] s390x: add function to set DAT mode for all interrupts Nico Boehr
2023-07-13 7:17 ` Thomas Huth
2023-07-13 8:23 ` Claudio Imbrenda
2023-07-13 15:30 ` Nico Boehr
2023-07-14 6:44 ` Thomas Huth
2023-07-14 10:38 ` Nico Boehr
2023-07-13 8:24 ` Claudio Imbrenda
2023-07-13 15:35 ` Nico Boehr
2023-07-12 11:41 ` [kvm-unit-tests PATCH v5 3/6] s390x: sie: switch to home space mode before entering SIE Nico Boehr
2023-07-13 7:28 ` Thomas Huth
2023-07-13 8:17 ` Claudio Imbrenda [this message]
2023-07-13 8:21 ` Thomas Huth
2023-07-14 8:21 ` Nico Boehr
2023-07-14 8:30 ` Thomas Huth
2023-07-14 10:31 ` Nico Boehr
2023-07-12 11:41 ` [kvm-unit-tests PATCH v5 4/6] s390x: lib: don't forward PSW when handling exception in SIE Nico Boehr
2023-07-12 11:41 ` [kvm-unit-tests PATCH v5 5/6] s390x: lib: sie: don't reenter SIE on pgm int Nico Boehr
2023-07-13 7:51 ` Thomas Huth
2023-07-12 11:41 ` [kvm-unit-tests PATCH v5 6/6] s390x: add a test for SIE without MSO/MSL Nico Boehr
2023-07-13 8:29 ` Thomas Huth
2023-07-14 8:35 ` Nico Boehr
2023-07-14 8:40 ` Thomas Huth
2023-07-14 10:39 ` Nico Boehr
2023-07-14 10:52 ` Thomas Huth
2023-08-01 6:51 ` Nico Boehr
2023-08-14 14:59 ` Thomas Huth
2023-08-15 11:30 ` Janosch Frank
2023-08-15 14:07 ` Thomas Huth
2023-08-15 14:26 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230713101707.1d1da214@p-imbrenda \
--to=imbrenda@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox