From: Lu Baolu <baolu.lu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Kevin Tian <kevin.tian@intel.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Nicolin Chen <nicolinc@nvidia.com>
Cc: Yi Liu <yi.l.liu@intel.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
iommu@lists.linux.dev, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, Lu Baolu <baolu.lu@linux.intel.com>
Subject: [PATCH v2 12/12] iommu: Add helper to set iopf handler for domain
Date: Thu, 27 Jul 2023 13:48:37 +0800 [thread overview]
Message-ID: <20230727054837.147050-13-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <20230727054837.147050-1-baolu.lu@linux.intel.com>
To avoid open code everywhere.
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
include/linux/iommu.h | 11 ++++++++++-
drivers/iommu/iommu.c | 20 ++++++++++++++++++--
2 files changed, 28 insertions(+), 3 deletions(-)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index d725500344a4..4e0b75befefc 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -132,6 +132,7 @@ struct iommu_page_response {
typedef int (*iommu_fault_handler_t)(struct iommu_domain *,
struct device *, unsigned long, int, void *);
+typedef int (*iommu_iopf_handler_t)(struct iopf_group *group);
struct iommu_domain_geometry {
dma_addr_t aperture_start; /* First address that can be mapped */
@@ -181,7 +182,7 @@ struct iommu_domain {
unsigned long pgsize_bitmap; /* Bitmap of page sizes in use */
struct iommu_domain_geometry geometry;
struct iommu_dma_cookie *iova_cookie;
- int (*iopf_handler)(struct iopf_group *group);
+ iommu_iopf_handler_t iopf_handler;
void *fault_data;
union {
struct {
@@ -581,6 +582,8 @@ extern ssize_t iommu_map_sg(struct iommu_domain *domain, unsigned long iova,
extern phys_addr_t iommu_iova_to_phys(struct iommu_domain *domain, dma_addr_t iova);
extern void iommu_set_fault_handler(struct iommu_domain *domain,
iommu_fault_handler_t handler, void *token);
+void iommu_domain_set_iopf_handler(struct iommu_domain *domain,
+ iommu_iopf_handler_t handler, void *data);
extern void iommu_get_resv_regions(struct device *dev, struct list_head *list);
extern void iommu_put_resv_regions(struct device *dev, struct list_head *list);
@@ -904,6 +907,12 @@ static inline void iommu_set_fault_handler(struct iommu_domain *domain,
{
}
+static inline void iommu_domain_set_iopf_handler(struct iommu_domain *domain,
+ iommu_iopf_handler_t handler,
+ void *data)
+{
+}
+
static inline void iommu_get_resv_regions(struct device *dev,
struct list_head *list)
{
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 9d964d16d0ad..2254b0ef91fb 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -1839,6 +1839,23 @@ void iommu_set_fault_handler(struct iommu_domain *domain,
}
EXPORT_SYMBOL_GPL(iommu_set_fault_handler);
+/**
+ * iommu_domain_set_iopf_handler() - set io page fault handler for a domain
+ * @domain: iommu domain
+ * @handler: fault handler
+ * @data: user data, will be passed back to the fault handler
+ *
+ * This function should be used by iommu domain users which want to be notified
+ * whenever an IOMMU I/O page fault happens.
+ */
+void iommu_domain_set_iopf_handler(struct iommu_domain *domain,
+ iommu_iopf_handler_t handler, void *data)
+{
+ domain->iopf_handler = handler;
+ domain->fault_data = data;
+}
+EXPORT_SYMBOL_GPL(iommu_domain_set_iopf_handler);
+
static struct iommu_domain *__iommu_domain_alloc(const struct bus_type *bus,
unsigned type)
{
@@ -3328,8 +3345,7 @@ struct iommu_domain *iommu_sva_domain_alloc(struct device *dev,
domain->type = IOMMU_DOMAIN_SVA;
mmgrab(mm);
domain->mm = mm;
- domain->iopf_handler = iommu_sva_handle_iopf_group;
- domain->fault_data = mm;
+ iommu_domain_set_iopf_handler(domain, iommu_sva_handle_iopf_group, mm);
return domain;
}
--
2.34.1
next prev parent reply other threads:[~2023-07-27 5:53 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 5:48 [PATCH v2 00/12] iommu: Prepare to deliver page faults to user space Lu Baolu
2023-07-27 5:48 ` [PATCH v2 01/12] iommu: Move iommu fault data to linux/iommu.h Lu Baolu
2023-08-03 7:53 ` Tian, Kevin
2023-08-04 2:51 ` Baolu Lu
2023-08-09 16:58 ` Jason Gunthorpe
2023-07-27 5:48 ` [PATCH v2 02/12] iommu/arm-smmu-v3: Remove unrecoverable faults reporting Lu Baolu
2023-07-27 5:48 ` [PATCH v2 03/12] iommu: Remove unrecoverable fault data Lu Baolu
2023-08-03 7:54 ` Tian, Kevin
2023-08-04 2:58 ` Baolu Lu
2023-08-04 3:51 ` Tian, Kevin
2023-08-04 5:34 ` Baolu Lu
2023-08-08 18:39 ` Jason Gunthorpe
2023-08-09 0:01 ` Tian, Kevin
2023-08-09 14:05 ` Jason Gunthorpe
2023-08-09 16:59 ` Jason Gunthorpe
2023-08-10 2:27 ` Baolu Lu
2023-08-10 16:46 ` Jason Gunthorpe
2023-08-11 1:15 ` Baolu Lu
2023-08-11 4:17 ` Tian, Kevin
2023-07-27 5:48 ` [PATCH v2 04/12] iommu: Replace device fault handler with iommu_queue_iopf() Lu Baolu
2023-08-03 7:55 ` Tian, Kevin
2023-08-10 18:22 ` Jason Gunthorpe
2023-08-11 1:23 ` Baolu Lu
2023-08-10 18:33 ` Jason Gunthorpe
2023-08-11 1:25 ` Baolu Lu
2023-07-27 5:48 ` [PATCH v2 05/12] iommu: Change the return value of dev_iommu_get() Lu Baolu
2023-08-03 7:59 ` Tian, Kevin
2023-08-04 3:10 ` Baolu Lu
2023-08-04 3:55 ` Tian, Kevin
2023-08-04 5:33 ` Baolu Lu
2023-08-09 16:58 ` Jason Gunthorpe
2023-08-10 2:30 ` Baolu Lu
2023-07-27 5:48 ` [PATCH v2 06/12] iommu: Make dev->fault_param static Lu Baolu
2023-08-03 8:08 ` Tian, Kevin
2023-08-04 3:16 ` Baolu Lu
2023-08-04 3:56 ` Tian, Kevin
2023-08-04 5:34 ` Baolu Lu
2023-08-10 18:20 ` Jason Gunthorpe
2023-08-10 18:46 ` Jason Gunthorpe
2023-08-11 1:43 ` Baolu Lu
2023-07-27 5:48 ` [PATCH v2 07/12] iommu: Remove iommu_[un]register_device_fault_handler() Lu Baolu
2023-08-03 8:09 ` Tian, Kevin
2023-08-10 18:59 ` Jason Gunthorpe
2023-07-27 5:48 ` [PATCH v2 08/12] iommu: Prepare for separating SVA and IOPF Lu Baolu
2023-08-03 8:16 ` Tian, Kevin
2023-08-04 3:26 ` Baolu Lu
2023-08-08 18:43 ` Jason Gunthorpe
2023-08-09 0:02 ` Tian, Kevin
2023-08-09 10:40 ` Baolu Lu
2023-08-10 2:35 ` Tian, Kevin
2023-08-10 16:47 ` Jason Gunthorpe
2023-08-11 1:53 ` Baolu Lu
2023-08-11 13:27 ` Jason Gunthorpe
2023-08-13 11:19 ` Baolu Lu
2023-07-27 5:48 ` [PATCH v2 09/12] iommu: Move iopf_handler() to iommu-sva.c Lu Baolu
2023-08-03 8:21 ` Tian, Kevin
2023-08-04 3:28 ` Baolu Lu
2023-08-10 19:02 ` Jason Gunthorpe
2023-08-11 1:55 ` Baolu Lu
2023-07-27 5:48 ` [PATCH v2 10/12] iommu: Make iommu_queue_iopf() more generic Lu Baolu
2023-08-10 19:07 ` Jason Gunthorpe
2023-08-11 2:21 ` Baolu Lu
2023-08-11 13:29 ` Jason Gunthorpe
2023-08-12 23:18 ` Baolu Lu
2023-07-27 5:48 ` [PATCH v2 11/12] iommu: Separate SVA and IOPF in Makefile and Kconfig Lu Baolu
2023-08-10 19:09 ` Jason Gunthorpe
2023-07-27 5:48 ` Lu Baolu [this message]
2023-08-10 19:18 ` [PATCH v2 12/12] iommu: Add helper to set iopf handler for domain Jason Gunthorpe
2023-08-11 2:40 ` Baolu Lu
2023-08-11 17:14 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230727054837.147050-13-baolu.lu@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jean-philippe@linaro.org \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox