From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC125C00528 for ; Fri, 4 Aug 2023 11:14:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229744AbjHDLOM (ORCPT ); Fri, 4 Aug 2023 07:14:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229650AbjHDLOK (ORCPT ); Fri, 4 Aug 2023 07:14:10 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2974D9B for ; Fri, 4 Aug 2023 04:14:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=c1ndwA3cij5JV4F1lad/blsX97FB0RbZpTmCxt0n92Q=; b=Vd7gNlemFqGAbY+3CL8bxfz1y5 sxElfTRTTEbCLba5y+lIlrMHy3x7WsS5axwW0ulXZkeqYZFzfvJ2/sgZmGA4UbtlTeKXFr6+Pqnhx agMgHtNxfiPCPjQLUqnlhEa99yFQ+TXCm4ZKLkZ+Gjfa5DBMaL4LU8gn1OsgXMuSr+zhKx9ejO+n1 2ZXofU523mmtJOE+YKQtoE3grX80XuBjHISPPd/RqEHbmzi/VEpp+xWfvfgh1laS0AHa/cPsrSPQR hwEGPdRxgh0sf+rPwOW6uiPcfqPLVdMaQVDBLs7AitNifo9NBjMpxXqJeXpDm8rEe1qvPNARA0QBV hR7p0aLg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qRskv-009XUn-2g; Fri, 04 Aug 2023 11:14:05 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id AEE7330020C; Fri, 4 Aug 2023 13:14:04 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 8CD072114A5F1; Fri, 4 Aug 2023 13:14:04 +0200 (CEST) Date: Fri, 4 Aug 2023 13:14:04 +0200 From: Peter Zijlstra To: Nikunj A Dadhania Cc: kvm@vger.kernel.org, Sean Christopherson , Josh Poimboeuf , Paolo Bonzini , Randy Dunlap , Tom Lendacky , Ravi Bangoria Subject: Re: [PATCH] KVM: SVM: Add exception to disable objtool warning for kvm-amd.o Message-ID: <20230804111404.GI214207@hirez.programming.kicks-ass.net> References: <20230802091107.1160320-1-nikunj@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230802091107.1160320-1-nikunj@amd.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Aug 02, 2023 at 02:41:07PM +0530, Nikunj A Dadhania wrote: > commit 7f4b5cde2409 ("kvm: Disable objtool frame pointer checking for > vmenter.S") had added the vmenter.o file to the exception list. > > objtool gives the following warnings in the newer kernel builds: > > arch/x86/kvm/kvm-amd.o: warning: objtool: __svm_vcpu_run+0x17d: BP used as a scratch register > arch/x86/kvm/kvm-amd.o: warning: objtool: __svm_sev_es_vcpu_run+0x72: BP used as a scratch register > I wanted to poke around a little, but can't reproduce this. I took x86_64-defconfig + KVM=m + KVM_AMD=m + UNWIND_FRAME_POINTER=y but objtool won't complain :/ What actual .config trips this?