From: Stefan Hajnoczi <stefanha@redhat.com>
To: kvm@vger.kernel.org
Cc: David Laight <David.Laight@ACULAB.COM>,
linux-kernel@vger.kernel.org, "Tian,
Kevin" <kevin.tian@intel.com>,
Alex Williamson <alex.williamson@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [PATCH v2 0/3] vfio: use __aligned_u64 for ioctl structs
Date: Tue, 29 Aug 2023 14:27:17 -0400 [thread overview]
Message-ID: <20230829182720.331083-1-stefanha@redhat.com> (raw)
v2:
- Rebased onto https://github.com/awilliam/linux-vfio.git next to get the
vfio_iommu_type1_info pad field [Kevin]
- Fixed min(minsz, sizeof(dmabuf)) -> min(dmabuf.argsz, sizeof(dmabuf)) [Jason, Kevin]
- Squashed Patch 3 (vfio_iommu_type1_info) into Patch 1 since it is trivial now
that the padding field is already there.
Jason Gunthorpe <jgg@nvidia.com> pointed out that u64 VFIO ioctl struct fields
have architecture-dependent alignment. iommufd already uses __aligned_u64 to
avoid this problem.
See the __aligned_u64 typedef in <uapi/linux/types.h> for details on why it is
a good idea for kernel<->user interfaces.
This series modifies the VFIO ioctl structs to use __aligned_u64. Some of the
changes preserve the existing memory layout on all architectures, so I put them
together into the first patch. The remaining patches are for structs where
explanation is necessary about why changing the memory layout does not break
the uapi.
Stefan Hajnoczi (3):
vfio: trivially use __aligned_u64 for ioctl structs
vfio: use __aligned_u64 in struct vfio_device_gfx_plane_info
vfio: use __aligned_u64 in struct vfio_device_ioeventfd
include/uapi/linux/vfio.h | 26 ++++++++++++++------------
drivers/gpu/drm/i915/gvt/kvmgt.c | 4 +++-
samples/vfio-mdev/mbochs.c | 6 ++++--
samples/vfio-mdev/mdpy.c | 4 +++-
4 files changed, 24 insertions(+), 16 deletions(-)
--
2.41.0
next reply other threads:[~2023-08-29 18:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 18:27 Stefan Hajnoczi [this message]
2023-08-29 18:27 ` [PATCH v2 1/3] vfio: trivially use __aligned_u64 for ioctl structs Stefan Hajnoczi
2023-08-31 8:45 ` Philippe Mathieu-Daudé
2023-09-11 6:06 ` Tian, Kevin
2023-08-29 18:27 ` [PATCH v2 2/3] vfio: use __aligned_u64 in struct vfio_device_gfx_plane_info Stefan Hajnoczi
2023-09-07 16:25 ` Jason Gunthorpe
2023-09-11 6:07 ` Tian, Kevin
2023-09-15 20:04 ` Alex Williamson
2023-09-18 14:15 ` Stefan Hajnoczi
2023-08-29 18:27 ` [PATCH v2 3/3] vfio: use __aligned_u64 in struct vfio_device_ioeventfd Stefan Hajnoczi
2023-09-11 6:08 ` Tian, Kevin
2023-08-29 21:10 ` [PATCH v2 0/3] vfio: use __aligned_u64 for ioctl structs David Laight
2023-08-30 8:32 ` David Laight
2023-08-30 21:53 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230829182720.331083-1-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=David.Laight@ACULAB.COM \
--cc=alex.williamson@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox