From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF05DCA0FE6 for ; Fri, 1 Sep 2023 05:50:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348303AbjIAFu1 (ORCPT ); Fri, 1 Sep 2023 01:50:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229829AbjIAFu1 (ORCPT ); Fri, 1 Sep 2023 01:50:27 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B1AB10C4 for ; Thu, 31 Aug 2023 22:50:24 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 2EFC468BEB; Fri, 1 Sep 2023 07:50:21 +0200 (CEST) Date: Fri, 1 Sep 2023 07:50:20 +0200 From: Christoph Hellwig To: Kim Phillips Cc: Christoph Hellwig , joro@8bytes.org, suravee.suthikulpanit@amd.com, iommu@lists.linux.dev, Michael Roth , "Kalra, Ashish" , "kvm@vger.kernel.org" , linux-coco@lists.linux.dev Subject: Re: [PATCH] iommu/amd: remove amd_iommu_snp_enable Message-ID: <20230901055020.GA31908@lst.de> References: <20230831123107.280998-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Aug 31, 2023 at 01:03:53PM -0500, Kim Phillips wrote: > +Mike Roth, Ashish > > On 8/31/23 7:31 AM, Christoph Hellwig wrote: >> amd_iommu_snp_enable is unused and has been since it was added in commit >> fb2accadaa94 ("iommu/amd: Introduce function to check and enable SNP"). >> >> Signed-off-by: Christoph Hellwig >> --- > > It is used by the forthcoming host SNP support: > > https://lore.kernel.org/lkml/20230612042559.375660-8-michael.roth@amd.com/ Then resend it with that support, but don't waste resources and everyones time now.