Re: [kvm-unit-tests PATCH v6 6/8] s390x: add test source dir to include paths

Thomas Huth
2023-09-04T10:38:52Z

On 04/09/2023 10.22, Nico Boehr wrote:
> Sometimes, it is useful to share some defines between a snippet and a
> test. By adding the source directory to include paths, header files can
> be placed in the snippet directory and included from the test (or vice
> versa).
>
> This is a prerequisite for "s390x: add a test for SIE without MSO/MSL".
>
> Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
> ---
> s390x/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/s390x/Makefile b/s390x/Makefile
> index 706be7920406..9d5c08339d16 100644
> --- a/s390x/Makefile
> +++ b/s390x/Makefile
> @@ -67,7 +67,7 @@ test_cases: $(tests)
> test_cases_binary: $(tests_binary)
> test_cases_pv: $(tests_pv_binary)
>
> -INCLUDE_PATHS = $(SRCDIR)/lib $(SRCDIR)/lib/s390x
> +INCLUDE_PATHS = $(SRCDIR)/lib $(SRCDIR)/lib/s390x $(SRCDIR)/s390x
> # Include generated header files (e.g. in case of out-of-source builds)
> INCLUDE_PATHS += lib
> CPPFLAGS = $(addprefix -I,$(INCLUDE_PATHS))

Reviewed-by: Thomas Huth <thuth@redhat.com>