Re: [kvm-unit-tests PATCH v6 8/8] lib: s390x: interrupt: remove TEID_ASCE defines

Thomas Huth
2023-09-04T10:40:20Z

On 04/09/2023 10.22, Nico Boehr wrote:
> These defines were - I can only guess - ment for the asce_id field.

s/ment/meant/

> Since print_decode_teid() used AS_PRIM and friends instead, I see little
> benefit in keeping these around.
>
> Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
> ---
> lib/s390x/asm/interrupt.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/lib/s390x/asm/interrupt.h b/lib/s390x/asm/interrupt.h
> index 7f73d473b346..48bd78fa1515 100644
> --- a/lib/s390x/asm/interrupt.h
> +++ b/lib/s390x/asm/interrupt.h
> @@ -13,11 +13,6 @@
> #define EXT_IRQ_EXTERNAL_CALL 0x1202
> #define EXT_IRQ_SERVICE_SIG 0x2401
>
> -#define TEID_ASCE_PRIMARY 0
> -#define TEID_ASCE_AR 1
> -#define TEID_ASCE_SECONDARY 2
> -#define TEID_ASCE_HOME 3
> -
> union teid {
> unsigned long val;
> union {

With the nit fixed:
Reviewed-by: Thomas Huth <thuth@redhat.com>