Re: [kvm-unit-tests PATCH v6 1/8] lib: s390x: introduce bitfield for PSW mask

Thomas Huth
2023-09-04T09:50:47Z

On 04/09/2023 10.22, Nico Boehr wrote:
> Changing the PSW mask is currently little clumsy, since there is only the
> PSW_MASK_* defines. This makes it hard to change e.g. only the address
> space in the current PSW without a lot of bit fiddling.
>
> Introduce a bitfield for the PSW mask. This makes this kind of
> modifications much simpler and easier to read.
>
> Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
> ---
> lib/s390x/asm/arch_def.h | 26 +++++++++++++++++++++++++-
> s390x/selftest.c | 34 ++++++++++++++++++++++++++++++++++
> 2 files changed, 59 insertions(+), 1 deletion(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>