From: Nico Boehr <nrb@linux.ibm.com>
To: frankja@linux.ibm.com, imbrenda@linux.ibm.com, thuth@redhat.com,
nsg@linux.ibm.com
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: [kvm-unit-tests PATCH v1] s390x: run PV guests with confidential guest enabled
Date: Mon, 25 Sep 2023 15:52:45 +0200 [thread overview]
Message-ID: <20230925135259.1685540-1-nrb@linux.ibm.com> (raw)
PV can only handle one page of SCLP read info, hence it can only support
a maximum of 247 CPUs.
To make sure we respect these limitations under PV, add a confidential
guest device to QEMU when launching a PV guest.
This fixes the topology-2 test failing under PV.
Also refactor the run script a bit to reduce code duplication by moving
the check whether we're running a PV guest to a function.
Suggested-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
---
s390x/run | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/s390x/run b/s390x/run
index dcbf3f036415..e58fa4af9f23 100755
--- a/s390x/run
+++ b/s390x/run
@@ -14,19 +14,34 @@ set_qemu_accelerator || exit $?
qemu=$(search_qemu_binary) ||
exit $?
-if [ "${1: -7}" = ".pv.bin" ] || [ "${TESTNAME: -3}" = "_PV" ] && [ "$ACCEL" = "tcg" ]; then
+is_pv() {
+ if [ "${1: -7}" = ".pv.bin" ] || [ "${TESTNAME: -3}" = "_PV" ]; then
+ return 0
+ fi
+ return 1
+}
+
+if is_pv && [ "$ACCEL" = "tcg" ]; then
echo "Protected Virtualization isn't supported under TCG"
exit 2
fi
-if [ "${1: -7}" = ".pv.bin" ] || [ "${TESTNAME: -3}" = "_PV" ] && [ "$MIGRATION" = "yes" ]; then
+if is_pv && [ "$MIGRATION" = "yes" ]; then
echo "Migration isn't supported under Protected Virtualization"
exit 2
fi
M='-machine s390-ccw-virtio'
M+=",accel=$ACCEL$ACCEL_PROPS"
+
+if is_pv; then
+ M+=",confidential-guest-support=pv0"
+fi
+
command="$qemu -nodefaults -nographic $M"
+if is_pv; then
+ command+=" -object s390-pv-guest,id=pv0"
+fi
command+=" -chardev stdio,id=con0 -device sclpconsole,chardev=con0"
command+=" -kernel"
command="$(panic_cmd) $(migration_cmd) $(timeout_cmd) $command"
--
2.41.0
next reply other threads:[~2023-09-25 13:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 13:52 Nico Boehr [this message]
2023-09-25 15:00 ` [kvm-unit-tests PATCH v1] s390x: run PV guests with confidential guest enabled Claudio Imbrenda
2023-09-25 15:59 ` Nina Schoetterl-Glausch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230925135259.1685540-1-nrb@linux.ibm.com \
--to=nrb@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nsg@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox