Re: [PATCH v2 7/7] KVM: selftests: x86: Use TAP interface in the userspace_msr_exit test

Thomas Huth
2024-02-08T19:31:14Z

On 26/01/2024 20.32, Sean Christopherson wrote:
> On Thu, Oct 05, 2023, Thomas Huth wrote:
>> Use the kselftest_harness.h interface in this test to get TAP
>> output, so that it is easier for the user to see what the test
>> is doing.
>>
>> Note: We're not using the KVM_ONE_VCPU_TEST() macro here (but the
>> generic TEST() macro from kselftest_harness.h) since each of the
>> tests needs a different guest code function.
>
> I would much rather we add a KVM framework that can deal with this, i.e. build
> something that is flexible from the get-go. Allowing tests to set the entry point
> after vCPU is fairly straightforward (patch below, compile tested only on x86).
>
> With that, my vote would be to have KVM_ONE_VCPU_TEST_SUITE() *always* pass NULL
> for the entry point, and instead always require sub-tests to pass the guest code
> to KVM_ONE_VCPU_TEST(). I think having the sub-test explicitly specify its guest
> code will be helpful for developers reading the code.

Yes, I agree that sounds quite a bit nicer. I'll give it a try...

Thomas