Re: [kvm-unit-tests PATCH 3/3] lib: s390x: sclp: Add line mode input handling

[Claudio Imbrenda <imbrenda@linux.ibm.com>]

On Tue, 10 Oct 2023 13:05:59 +0200
Janosch Frank <frankja@linux.ibm.com> wrote:

> On 10/10/23 12:33, Claudio Imbrenda wrote:
> > On Tue, 10 Oct 2023 07:38:55 +0000
> > Janosch Frank <frankja@linux.ibm.com> wrote:
> >   
> >> Time to add line-mode input so we can use input handling under LPAR if
> >> there's no access to a ASCII console.
> >>
> >> Line-mode IO is pretty wild and the documentation could be improved a
> >> lot. Hence I've copied the input parsing functions from Linux.
> >>
> >> For some reason output is a type 2 event but input is a type 1
> >> event. This also means that the input and output structures are
> >> different from each other.
> >>
> >> The input can consist of multiple structures which don't contain text
> >> data before the input text data is reached. Hence we need a bunch of
> >> search functions to retrieve a pointer to the text data.
> >>
> >> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> >> ---
> >>   lib/s390x/sclp-console.c | 180 ++++++++++++++++++++++++++++++++++-----
> >>   lib/s390x/sclp.h         |  26 +++++-
> >>   2 files changed, 185 insertions(+), 21 deletions(-)
> >>
> >> diff --git a/lib/s390x/sclp-console.c b/lib/s390x/sclp-console.c
> >> index 313be1e4..23c09b70 100644
> >> --- a/lib/s390x/sclp-console.c
> >> +++ b/lib/s390x/sclp-console.c
> >> @@ -1,8 +1,12 @@
> >>   /* SPDX-License-Identifier: GPL-2.0-or-later */
> >>   /*
> >> - * SCLP ASCII access driver
> >> + * SCLP line mode and ASCII console driver
> >>    *
> >>    * Copyright (c) 2013 Alexander Graf <agraf@suse.de>
> >> + *
> >> + * Copyright IBM Corp. 1999
> >> + * Author(s): Martin Peschke <mpeschke@de.ibm.com>
> >> + *	      Martin Schwidefsky <schwidefsky@de.ibm.com>  
> > 
> > from the weird copyright notices that you are adding I deduce that you
> > copied those functions from the kernel. maybe add a line in the patch
> > description to say so? or at least explain better in the comment itself.  
> 
> You mean this line which is in the patch description?
> "Hence I've copied the input parsing functions from Linux."

oufff, I'm blind sorry

> 
> But sure, I could add that after "SCLP line mode and ASCII console driver"

yeah that would bring it in line with the rest of the other files which
have been (partially) copied from the kernel