Re: [PATCH v3 05/19] iommufd/selftest: Expand mock_domain with dev_flags

Joao Martins
2023-10-13T16:22:35Z

On 13/10/2023 17:02, Jason Gunthorpe wrote:
> On Sat, Sep 23, 2023 at 02:24:57AM +0100, Joao Martins wrote:
>
>> @@ -56,6 +61,13 @@ struct iommu_test_cmd {
>> /* out_idev_id is the standard iommufd_bind object */
>> __u32 out_idev_id;
>> } mock_domain;
>> + struct {
>> + __u32 out_stdev_id;
>> + __u32 out_hwpt_id;
>> + __u32 out_idev_id;
>> + /* Expand mock_domain to set mock device flags */
>> + __u32 dev_flags;
>> + } mock_domain_flags;
>
> I wonder if this is really needed? Did this change make the struct
> bigger?
>

This was addressing your earlier comment where I could be breaking ABI, by
adding dev_flags top the end of mock_domain anon struct. So figured the simplest
and less ugly to existing mock_domain flow.

I didn't explicitly checked the size of the struct exactly, but just lookign at
it there's bigger ones for sure that the mock_domain_flags I added. e.g.
check_map with 3 u64, or access_pages