Re: [PATCH v3 01/19] vfio/iova_bitmap: Export more API symbols

Jason Gunthorpe
2023-10-13T16:03:23Z

On Fri, Oct 13, 2023 at 04:57:53PM +0100, Joao Martins wrote:
> On 13/10/2023 16:43, Jason Gunthorpe wrote:
> > On Sat, Sep 23, 2023 at 02:24:53AM +0100, Joao Martins wrote:
> >> In preparation to move iova_bitmap into iommufd, export the rest of API
> >> symbols that will be used in what could be used by modules, namely:
> >>
> >> iova_bitmap_alloc
> >> iova_bitmap_free
> >> iova_bitmap_for_each
> >>
> >> Suggested-by: Alex Williamson <alex.williamson@redhat.com>
> >> Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
> >> ---
> >> drivers/vfio/iova_bitmap.c | 3 +++
> >> 1 file changed, 3 insertions(+)
> >
> > All iommufd symbols should be exported more like:
> >
> > drivers/iommu/iommufd/device.c:EXPORT_SYMBOL_NS_GPL(iommufd_device_replace, IOMMUFD);
> >
> > Including these. So please fix them all here too
>
> OK, Provided your comment on the next patch to move this into IOMMUFD.
>
> The IOMMU core didn't exported symbols that way, so I adhered to the style in-use.

Well, this commit message says "move iova_bitmap into iommufd" :)

Jason