Re: [PATCH v3 19/19] iommu/intel: Access/Dirty bit support for SL domains

Jason Gunthorpe
2023-10-16T12:59:51Z

On Mon, Oct 16, 2023 at 08:58:42PM +0800, Baolu Lu wrote:
> On 2023/10/16 19:42, Jason Gunthorpe wrote:
> > On Mon, Oct 16, 2023 at 11:57:34AM +0100, Joao Martins wrote:
> >
> > > True. But to be honest, I thought we weren't quite there yet in PASID support
> > > from IOMMUFD perspective; hence why I didn't aim at it. Or do I have the wrong
> > > impression? From the code below, it clearly looks the driver does.
> > I think we should plan that this series will go before the PASID
> > series
>
> I know that PASID support in IOMMUFD is not yet available, but the VT-d
> driver already supports attaching a domain to a PASID, as required by
> the idxd driver for kernel DMA with PASID. Therefore, from the driver's
> perspective, dirty tracking should also be enabled for PASIDs.

As long as the driver refuses to attach a dirty track enabled domain
to PASID it would be fine for now.

Jason