Re: [PATCH v3 16/19] iommu/amd: Add domain_alloc_user based domain allocation

Jason Gunthorpe
2023-10-17T15:32:17Z

On Tue, Oct 17, 2023 at 03:37:47PM +0100, Joao Martins wrote:
> On 17/10/2023 15:14, Joao Martins wrote:
> > On 17/10/2023 14:10, Jason Gunthorpe wrote:
> >> On Tue, Oct 17, 2023 at 10:07:11AM +0100, Joao Martins wrote:
> >>>
> >>> static struct iommu_domain *do_iommu_domain_alloc(unsigned int type,
> >>> - struct amd_iommu *iommu,
> >>> struct device *dev,
> >>> u32 flags)
> >>> {
> >>> struct protection_domain *domain;
> >>> + struct amd_iommu *iommu = NULL;
> >>> +
> >>> + if (dev) {
> >>> + iommu = rlookup_amd_iommu(dev);
> >>> + if (!iommu)
> >>
> >> This really shouldn't be rlookup_amd_iommu, didn't the series fixing
> >> this get merged?
> >
> > From the latest linux-next, it's still there.
> >
> I'm assuming you refer to this new helper:
>
> https://lore.kernel.org/linux-iommu/20231013151652.6008-3-vasant.hegde@amd.com/
>
> But it's part 3 out of a 4-part multi-series; and only the first part has been
> merged.

Okay, then nothing to do here :\

Jason