From: Jason Gunthorpe <jgg@nvidia.com>
To: Joao Martins <joao.m.martins@oracle.com>
Cc: iommu@lists.linux.dev, Kevin Tian <kevin.tian@intel.com>,
Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>,
Lu Baolu <baolu.lu@linux.intel.com>, Yi Liu <yi.l.liu@intel.com>,
Yi Y Sun <yi.y.sun@intel.com>, Nicolin Chen <nicolinc@nvidia.com>,
Joerg Roedel <joro@8bytes.org>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Zhenzhong Duan <zhenzhong.duan@intel.com>,
Alex Williamson <alex.williamson@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH v4 06/18] iommufd: Add IOMMU_HWPT_SET_DIRTY
Date: Wed, 18 Oct 2023 19:28:43 -0300 [thread overview]
Message-ID: <20231018222843.GK3952@nvidia.com> (raw)
In-Reply-To: <20231018202715.69734-7-joao.m.martins@oracle.com>
On Wed, Oct 18, 2023 at 09:27:03PM +0100, Joao Martins wrote:
> Every IOMMU driver should be able to implement the needed iommu domain ops
> to control dirty tracking.
>
> Connect a hw_pagetable to the IOMMU core dirty tracking ops, specifically
> the ability to enable/disable dirty tracking on an IOMMU domain
> (hw_pagetable id). To that end add an io_pagetable kernel API to toggle
> dirty tracking:
>
> * iopt_set_dirty_tracking(iopt, [domain], state)
>
> The intended caller of this is via the hw_pagetable object that is created.
>
> Internally it will ensure the leftover dirty state is cleared /right
> before/ dirty tracking starts. This is also useful for iommu drivers which
> may decide that dirty tracking is always-enabled at boot without wanting to
> toggle dynamically via corresponding iommu domain op.
>
> Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
> ---
> drivers/iommu/iommufd/hw_pagetable.c | 24 +++++++++++
> drivers/iommu/iommufd/io_pagetable.c | 55 +++++++++++++++++++++++++
> drivers/iommu/iommufd/iommufd_private.h | 12 ++++++
> drivers/iommu/iommufd/main.c | 3 ++
> include/uapi/linux/iommufd.h | 25 +++++++++++
> 5 files changed, 119 insertions(+)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
next prev parent reply other threads:[~2023-10-18 22:48 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 20:26 [PATCH v4 00/18] IOMMUFD Dirty Tracking Joao Martins
2023-10-18 20:26 ` [PATCH v4 01/18] vfio/iova_bitmap: Export more API symbols Joao Martins
2023-10-18 22:14 ` Jason Gunthorpe
2023-10-20 5:45 ` Tian, Kevin
2023-10-20 16:44 ` Alex Williamson
2023-10-18 20:26 ` [PATCH v4 02/18] vfio: Move iova_bitmap into iommufd Joao Martins
2023-10-18 22:14 ` Jason Gunthorpe
2023-10-19 17:48 ` Brett Creeley
2023-10-20 5:46 ` Tian, Kevin
2023-10-20 16:44 ` Alex Williamson
2023-10-18 20:27 ` [PATCH v4 03/18] iommufd/iova_bitmap: Move symbols to IOMMUFD namespace Joao Martins
2023-10-18 22:16 ` Jason Gunthorpe
2023-10-19 17:48 ` Brett Creeley
2023-10-20 5:47 ` Tian, Kevin
2023-10-20 16:44 ` Alex Williamson
2023-10-18 20:27 ` [PATCH v4 04/18] iommu: Add iommu_domain ops for dirty tracking Joao Martins
2023-10-18 22:26 ` Jason Gunthorpe
2023-10-19 1:45 ` Baolu Lu
2023-10-20 5:54 ` Tian, Kevin
2023-10-20 11:24 ` Joao Martins
2023-10-18 20:27 ` [PATCH v4 05/18] iommufd: Add a flag to enforce dirty tracking on attach Joao Martins
2023-10-18 22:26 ` Jason Gunthorpe
2023-10-18 22:38 ` Jason Gunthorpe
2023-10-18 23:38 ` Joao Martins
2023-10-20 5:55 ` Tian, Kevin
2023-10-18 20:27 ` [PATCH v4 06/18] iommufd: Add IOMMU_HWPT_SET_DIRTY Joao Martins
2023-10-18 22:28 ` Jason Gunthorpe [this message]
2023-10-20 6:09 ` Tian, Kevin
2023-10-20 15:30 ` Joao Martins
2023-10-20 7:56 ` Tian, Kevin
2023-10-20 20:41 ` Joao Martins
2023-10-18 20:27 ` [PATCH v4 07/18] iommufd: Add IOMMU_HWPT_GET_DIRTY_IOVA Joao Martins
2023-10-18 22:39 ` Jason Gunthorpe
2023-10-18 23:43 ` Joao Martins
2023-10-19 12:01 ` Jason Gunthorpe
2023-10-19 12:04 ` Joao Martins
2023-10-19 10:01 ` Joao Martins
2023-10-20 6:32 ` Tian, Kevin
2023-10-20 11:53 ` Joao Martins
2023-10-20 13:40 ` Jason Gunthorpe
2023-10-18 20:27 ` [PATCH v4 08/18] iommufd: Add capabilities to IOMMU_GET_HW_INFO Joao Martins
2023-10-18 22:44 ` Jason Gunthorpe
2023-10-19 9:55 ` Joao Martins
2023-10-19 23:56 ` Jason Gunthorpe
2023-10-20 6:46 ` Tian, Kevin
2023-10-20 11:52 ` Joao Martins
2023-10-18 20:27 ` [PATCH v4 09/18] iommufd: Add a flag to skip clearing of IOPTE dirty Joao Martins
2023-10-18 22:54 ` Jason Gunthorpe
2023-10-18 23:50 ` Joao Martins
2023-10-20 6:52 ` Tian, Kevin
2023-10-18 20:27 ` [PATCH v4 10/18] iommu/amd: Add domain_alloc_user based domain allocation Joao Martins
2023-10-18 22:58 ` Jason Gunthorpe
2023-10-18 23:54 ` Joao Martins
2023-10-18 20:27 ` [PATCH v4 11/18] iommu/amd: Access/Dirty bit support in IOPTEs Joao Martins
2023-10-18 23:11 ` Jason Gunthorpe
2023-10-19 0:17 ` Joao Martins
2023-10-19 11:58 ` Joao Martins
2023-10-19 23:59 ` Jason Gunthorpe
2023-10-20 14:43 ` Joao Martins
2023-10-20 21:22 ` Joao Martins
2023-10-21 16:14 ` Jason Gunthorpe
2023-10-22 7:07 ` Yishai Hadas
2023-10-20 2:21 ` Baolu Lu
2023-10-20 7:01 ` Tian, Kevin
2023-10-20 9:34 ` Joao Martins
2023-10-20 11:20 ` Joao Martins
2023-10-20 18:57 ` Joao Martins
2023-10-18 20:27 ` [PATCH v4 12/18] iommu/intel: Access/Dirty bit support for SL domains Joao Martins
2023-10-19 3:04 ` Baolu Lu
2023-10-19 9:14 ` Joao Martins
2023-10-19 10:33 ` Joao Martins
2023-10-19 23:56 ` Jason Gunthorpe
2023-10-20 10:12 ` Joao Martins
2023-10-20 7:53 ` Tian, Kevin
2023-10-20 9:15 ` Baolu Lu
2023-10-18 20:27 ` [PATCH v4 13/18] iommufd/selftest: Expand mock_domain with dev_flags Joao Martins
2023-10-20 7:57 ` Tian, Kevin
2023-10-18 20:27 ` [PATCH v4 14/18] iommufd/selftest: Test IOMMU_HWPT_ALLOC_ENFORCE_DIRTY Joao Martins
2023-10-20 7:59 ` Tian, Kevin
2023-10-18 20:27 ` [PATCH v4 15/18] iommufd/selftest: Test IOMMU_HWPT_SET_DIRTY Joao Martins
2023-10-20 8:00 ` Tian, Kevin
2023-10-18 20:27 ` [PATCH v4 16/18] iommufd/selftest: Test IOMMU_HWPT_GET_DIRTY_IOVA Joao Martins
2023-10-18 20:27 ` [PATCH v4 17/18] iommufd/selftest: Test out_capabilities in IOMMU_GET_HW_INFO Joao Martins
2023-10-18 20:27 ` [PATCH v4 18/18] iommufd/selftest: Test IOMMU_GET_DIRTY_IOVA_NO_CLEAR flag Joao Martins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018222843.GK3952@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=joao.m.martins@oracle.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
--cc=yi.y.sun@intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox