From: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
To: "Claudio Imbrenda" <imbrenda@linux.ibm.com>,
"Janosch Frank" <frankja@linux.ibm.com>,
"Nico Böhr" <nrb@linux.ibm.com>
Cc: Nina Schoetterl-Glausch <nsg@linux.ibm.com>,
Thomas Huth <thuth@redhat.com>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org,
Colton Lewis <coltonlewis@google.com>,
Shaoqin Huang <shahuang@redhat.com>,
Nikos Nikoleris <nikos.nikoleris@arm.com>,
David Hildenbrand <david@redhat.com>,
Ricardo Koller <ricarkol@google.com>,
Sean Christopherson <seanjc@google.com>,
Andrew Jones <andrew.jones@linux.dev>
Subject: [kvm-unit-tests PATCH 04/10] s390x: topology: Fix parsing loop
Date: Fri, 20 Oct 2023 16:48:54 +0200 [thread overview]
Message-ID: <20231020144900.2213398-5-nsg@linux.ibm.com> (raw)
In-Reply-To: <20231020144900.2213398-1-nsg@linux.ibm.com>
Without a comparison the loop is infinite.
Reviewed-by: Nico Boehr <nrb@linux.ibm.com>
Signed-off-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
---
s390x/topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/s390x/topology.c b/s390x/topology.c
index 032e80dc..c8ad4bcb 100644
--- a/s390x/topology.c
+++ b/s390x/topology.c
@@ -468,7 +468,7 @@ static void parse_topology_args(int argc, char **argv)
if (flag[0] != '-')
report_abort("Argument is expected to begin with '-'");
flag++;
- for (level = 0; ARRAY_SIZE(levels); level++) {
+ for (level = 0; level < ARRAY_SIZE(levels); level++) {
if (!strcmp(levels[level], flag))
break;
}
--
2.41.0
next prev parent reply other threads:[~2023-10-20 15:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 14:48 [kvm-unit-tests PATCH 00/10] s390x: topology: Fixes and extension Nina Schoetterl-Glausch
2023-10-20 14:48 ` [kvm-unit-tests PATCH 01/10] s390x: topology: Introduce enums for polarization & cpu type Nina Schoetterl-Glausch
2023-10-25 11:56 ` Nico Boehr
2023-10-25 11:58 ` Janosch Frank
2023-10-20 14:48 ` [kvm-unit-tests PATCH 02/10] s390x: topology: Fix report message Nina Schoetterl-Glausch
2023-10-25 11:59 ` Janosch Frank
2023-10-20 14:48 ` [kvm-unit-tests PATCH 03/10] s390x: topology: Use function parameter in stsi_get_sysib Nina Schoetterl-Glausch
2023-10-20 14:48 ` Nina Schoetterl-Glausch [this message]
2023-10-25 12:00 ` [kvm-unit-tests PATCH 04/10] s390x: topology: Fix parsing loop Janosch Frank
2023-10-20 14:48 ` [kvm-unit-tests PATCH 05/10] s390x: topology: Make some report messages unique Nina Schoetterl-Glausch
2023-10-20 14:48 ` [kvm-unit-tests PATCH 06/10] s390x: topology: Refine stsi header test Nina Schoetterl-Glausch
2023-10-25 14:11 ` Janosch Frank
2023-10-20 14:48 ` [kvm-unit-tests PATCH 07/10] s390x: topology: Rename topology_core to topology_cpu Nina Schoetterl-Glausch
2023-10-20 14:48 ` [kvm-unit-tests PATCH 08/10] s390x: topology: Rewrite topology list test Nina Schoetterl-Glausch
2023-10-20 14:48 ` [kvm-unit-tests PATCH 09/10] scripts: Implement multiline strings for extra_params Nina Schoetterl-Glausch
2023-10-25 17:50 ` Thomas Huth
2023-10-25 17:58 ` Nina Schoetterl-Glausch
2023-10-20 14:49 ` [kvm-unit-tests PATCH 10/10] s390x: topology: Add complex topology test Nina Schoetterl-Glausch
2023-10-25 12:21 ` [kvm-unit-tests PATCH 00/10] s390x: topology: Fixes and extension Nico Boehr
[not found] ` <0f132157ec6437326c6bd63f8be18976b19f058a.camel@linux.ibm.com>
2023-10-30 7:30 ` Nico Boehr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020144900.2213398-5-nsg@linux.ibm.com \
--to=nsg@linux.ibm.com \
--cc=andrew.jones@linux.dev \
--cc=coltonlewis@google.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nikos.nikoleris@arm.com \
--cc=nrb@linux.ibm.com \
--cc=ricarkol@google.com \
--cc=seanjc@google.com \
--cc=shahuang@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox