From: Jason Gunthorpe <jgg@nvidia.com>
To: Arnd Bergmann <arnd@kernel.org>,
Joao Martins <joao.m.martins@oracle.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Arnd Bergmann <arnd@arndb.de>,
Yishai Hadas <yishaih@nvidia.com>,
Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
Alex Williamson <alex.williamson@redhat.com>,
Brett Creeley <brett.creeley@amd.com>,
Shixiong Ou <oushixiong@kylinos.cn>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio: mlx5, pds: add IOMMU_SUPPORT dependency
Date: Mon, 23 Oct 2023 09:04:18 -0300 [thread overview]
Message-ID: <20231023120418.GH691768@ziepe.ca> (raw)
In-Reply-To: <20231023115520.3530120-1-arnd@kernel.org>
On Mon, Oct 23, 2023 at 01:55:03PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Selecting IOMMUFD_DRIVER is not allowed if IOMMUs themselves are not supported:
>
> WARNING: unmet direct dependencies detected for IOMMUFD_DRIVER
> Depends on [n]: IOMMU_SUPPORT [=n]
> Selected by [m]:
> - MLX5_VFIO_PCI [=m] && VFIO [=y] && PCI [=y] && MMU [=y] && MLX5_CORE [=y]
>
> There is no actual build failure, only the warning.
>
> Make the 'select' conditional using the same logic that we have for
> INTEL_IOMMU and AMD_IOMMU.
>
> Fixes: 33f6339534287 ("vfio: Move iova_bitmap into iommufd")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/vfio/pci/mlx5/Kconfig | 2 +-
> drivers/vfio/pci/pds/Kconfig | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
But this isn't the logic this wants, it wants to turn on
IOMMUFD_DRIVER if MLX5_VFIO_PCI is turned on.
I think it means IOMMUFD_DRIVER should be lifted out of the
IOMMU_SUPPORT block somehow. I guess just move it into the top of
drivers/iommu/Kconfig?
Jason
next prev parent reply other threads:[~2023-10-23 12:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 11:55 [PATCH] vfio: mlx5, pds: add IOMMU_SUPPORT dependency Arnd Bergmann
2023-10-23 12:04 ` Jason Gunthorpe [this message]
2023-10-23 12:37 ` Joao Martins
2023-10-23 12:55 ` Arnd Bergmann
2023-10-23 13:23 ` Jason Gunthorpe
2023-10-23 14:02 ` Arnd Bergmann
2023-10-23 14:19 ` Jason Gunthorpe
2023-10-23 14:35 ` Arnd Bergmann
2023-10-23 14:43 ` Jason Gunthorpe
2023-10-23 14:52 ` Arnd Bergmann
2023-10-23 13:12 ` Jason Gunthorpe
2023-10-23 17:50 ` Joao Martins
2023-10-23 18:08 ` Jason Gunthorpe
2023-10-23 18:46 ` Arnd Bergmann
2023-10-23 20:23 ` Joao Martins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231023120418.GH691768@ziepe.ca \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=brett.creeley@amd.com \
--cc=joao.m.martins@oracle.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oushixiong@kylinos.cn \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox