From: Jason Gunthorpe <jgg@nvidia.com>
To: Joao Martins <joao.m.martins@oracle.com>
Cc: Arnd Bergmann <arnd@kernel.org>,
Kevin Tian <kevin.tian@intel.com>, Arnd Bergmann <arnd@arndb.de>,
Yishai Hadas <yishaih@nvidia.com>,
Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
Alex Williamson <alex.williamson@redhat.com>,
Brett Creeley <brett.creeley@amd.com>,
Shixiong Ou <oushixiong@kylinos.cn>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio: mlx5, pds: add IOMMU_SUPPORT dependency
Date: Mon, 23 Oct 2023 15:08:55 -0300 [thread overview]
Message-ID: <20231023180855.GG3952@nvidia.com> (raw)
In-Reply-To: <3b731349-38e4-43bd-9482-6fe43871b679@oracle.com>
On Mon, Oct 23, 2023 at 06:50:05PM +0100, Joao Martins wrote:
> On 23/10/2023 14:12, Jason Gunthorpe wrote:
> > On Mon, Oct 23, 2023 at 01:37:28PM +0100, Joao Martins wrote:
> >
> >> iommufd Kconfig is only included in the IOMMU_SUPPORT kconfig if clause; so
> >> moving it out from the iommufd kconfig out into iommu kconfig should fix it.
> >> Didn't realize that one can select IOMMU_API yet have IOMMU_SUPPORT unset/unmet.
> >> I'll make the move in v6
> >
> > I think this is some cruft that accumulated over the years, it doesn't
> > make alot of sense that there are two kconfigs now..
>
> To be specific what I meant to move is the IOMMUFD_DRIVER kconfig part, not the
> whole iommufd Kconfig [in the patch introducing the problem] e.g.
yes
> Perhaps the merging of IOMMU_API with IOMMU_SUPPORT should be best done separately?
Yes
Jason
next prev parent reply other threads:[~2023-10-23 18:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 11:55 [PATCH] vfio: mlx5, pds: add IOMMU_SUPPORT dependency Arnd Bergmann
2023-10-23 12:04 ` Jason Gunthorpe
2023-10-23 12:37 ` Joao Martins
2023-10-23 12:55 ` Arnd Bergmann
2023-10-23 13:23 ` Jason Gunthorpe
2023-10-23 14:02 ` Arnd Bergmann
2023-10-23 14:19 ` Jason Gunthorpe
2023-10-23 14:35 ` Arnd Bergmann
2023-10-23 14:43 ` Jason Gunthorpe
2023-10-23 14:52 ` Arnd Bergmann
2023-10-23 13:12 ` Jason Gunthorpe
2023-10-23 17:50 ` Joao Martins
2023-10-23 18:08 ` Jason Gunthorpe [this message]
2023-10-23 18:46 ` Arnd Bergmann
2023-10-23 20:23 ` Joao Martins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231023180855.GG3952@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=brett.creeley@amd.com \
--cc=joao.m.martins@oracle.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oushixiong@kylinos.cn \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox