From: "Michael S. Tsirkin" <mst@redhat.com>
To: Yishai Hadas <yishaih@nvidia.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
jasowang@redhat.com, jgg@nvidia.com, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org, parav@nvidia.com,
feliu@nvidia.com, jiri@nvidia.com, kevin.tian@intel.com,
joao.m.martins@oracle.com, si-wei.liu@oracle.com,
leonro@nvidia.com, maorg@nvidia.com
Subject: Re: [PATCH V1 vfio 9/9] vfio/virtio: Introduce a vfio driver over virtio devices
Date: Wed, 25 Oct 2023 12:28:37 -0400 [thread overview]
Message-ID: <20231025122625-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <d6c720a0-1575-45b7-b96d-03a916310699@nvidia.com>
On Wed, Oct 25, 2023 at 05:35:51PM +0300, Yishai Hadas wrote:
> > Do we want to make this only probe the correct subsystem vendor ID or do
> > we want to emulate the subsystem vendor ID as well? I don't see this is
> > correct without one of those options.
>
> Looking in the 1.x spec we can see the below.
>
> Legacy Interfaces: A Note on PCI Device Discovery
>
> "Transitional devices MUST have the PCI Subsystem
> Device ID matching the Virtio Device ID, as indicated in section 5 ...
> This is to match legacy drivers."
>
> However, there is no need to enforce Subsystem Vendor ID.
>
> This is what we followed here.
>
> Makes sense ?
Won't work for legacy windows drivers.
--
MST
next prev parent reply other threads:[~2023-10-25 16:29 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 13:42 [PATCH V1 vfio 0/9] Introduce a vfio driver over virtio devices Yishai Hadas
2023-10-17 13:42 ` [PATCH V1 vfio 1/9] virtio-pci: Fix common config map for modern device Yishai Hadas
2023-10-17 13:42 ` [PATCH V1 vfio 2/9] virtio: Define feature bit for administration virtqueue Yishai Hadas
2023-10-17 13:42 ` [PATCH V1 vfio 3/9] virtio-pci: Introduce admin virtqueue Yishai Hadas
2023-10-17 13:42 ` [PATCH V1 vfio 4/9] virtio-pci: Introduce admin command sending function Yishai Hadas
2023-10-17 13:42 ` [PATCH V1 vfio 5/9] virtio-pci: Introduce admin commands Yishai Hadas
2023-10-17 13:42 ` [PATCH V1 vfio 6/9] virtio-pci: Introduce APIs to execute legacy IO " Yishai Hadas
2023-10-17 20:33 ` kernel test robot
2023-10-22 1:14 ` kernel test robot
2023-10-24 21:01 ` Michael S. Tsirkin
2023-10-25 9:36 ` Yishai Hadas
[not found] ` <5a83e6c1-1d32-4edb-a01c-3660ab74d875@nvidia.com>
2023-10-25 10:17 ` Michael S. Tsirkin
2023-10-25 13:00 ` Yishai Hadas
2023-10-25 13:04 ` Michael S. Tsirkin
2023-10-25 13:44 ` Michael S. Tsirkin
2023-10-25 14:03 ` Yishai Hadas
2023-10-25 16:31 ` Michael S. Tsirkin
2023-10-17 13:42 ` [PATCH V1 vfio 7/9] vfio/pci: Expose vfio_pci_core_setup_barmap() Yishai Hadas
2023-10-17 13:42 ` [PATCH V1 vfio 8/9] vfio/pci: Expose vfio_pci_iowrite/read##size() Yishai Hadas
2023-10-17 13:42 ` [PATCH V1 vfio 9/9] vfio/virtio: Introduce a vfio driver over virtio devices Yishai Hadas
2023-10-17 20:24 ` Alex Williamson
2023-10-18 9:01 ` Yishai Hadas
2023-10-18 12:51 ` Alex Williamson
2023-10-18 13:06 ` Parav Pandit
2023-10-18 16:33 ` Jason Gunthorpe
2023-10-18 18:29 ` Alex Williamson
2023-10-18 19:28 ` Jason Gunthorpe
2023-10-24 19:57 ` Alex Williamson
2023-10-25 14:35 ` Yishai Hadas
2023-10-25 16:28 ` Michael S. Tsirkin [this message]
2023-10-25 19:13 ` Alex Williamson
2023-10-26 12:08 ` Yishai Hadas
2023-10-26 12:12 ` Michael S. Tsirkin
2023-10-26 12:40 ` Parav Pandit
2023-10-26 13:15 ` Michael S. Tsirkin
2023-10-26 13:28 ` Parav Pandit
2023-10-26 15:06 ` Michael S. Tsirkin
2023-10-26 15:09 ` Parav Pandit
2023-10-26 15:46 ` Michael S. Tsirkin
2023-10-26 15:56 ` Parav Pandit
2023-10-26 17:55 ` Alex Williamson
2023-10-26 19:49 ` Michael S. Tsirkin
2023-10-29 16:13 ` Yishai Hadas
2023-10-22 8:20 ` [PATCH V1 vfio 0/9] " Yishai Hadas
2023-10-22 9:12 ` Michael S. Tsirkin
2023-10-23 15:33 ` Alex Williamson
2023-10-23 15:42 ` Jason Gunthorpe
2023-10-23 16:09 ` Alex Williamson
2023-10-23 16:20 ` Jason Gunthorpe
2023-10-23 16:45 ` Alex Williamson
2023-10-23 17:27 ` Jason Gunthorpe
2023-10-25 8:34 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025122625-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=feliu@nvidia.com \
--cc=jasowang@redhat.com \
--cc=jgg@nvidia.com \
--cc=jiri@nvidia.com \
--cc=joao.m.martins@oracle.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=leonro@nvidia.com \
--cc=maorg@nvidia.com \
--cc=parav@nvidia.com \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox