Re: [PATCH V1 vfio 9/9] vfio/virtio: Introduce a vfio driver over virtio devices

Michael S. Tsirkin
2023-10-25T16:29:37Z

On Wed, Oct 25, 2023 at 05:35:51PM +0300, Yishai Hadas wrote:
> > Do we want to make this only probe the correct subsystem vendor ID or do
> > we want to emulate the subsystem vendor ID as well? I don't see this is
> > correct without one of those options.
>
> Looking in the 1.x spec we can see the below.
>
> Legacy Interfaces: A Note on PCI Device Discovery
>
> "Transitional devices MUST have the PCI Subsystem
> Device ID matching the Virtio Device ID, as indicated in section 5 ...
> This is to match legacy drivers."
>
> However, there is no need to enforce Subsystem Vendor ID.
>
> This is what we followed here.
>
> Makes sense ?

Won't work for legacy windows drivers.

--
MST