From: Nikunj A Dadhania <nikunj@amd.com>
To: <linux-kernel@vger.kernel.org>, <thomas.lendacky@amd.com>,
<x86@kernel.org>, <kvm@vger.kernel.org>
Cc: <bp@alien8.de>, <mingo@redhat.com>, <tglx@linutronix.de>,
<dave.hansen@linux.intel.com>, <dionnaglaze@google.com>,
<pgonda@google.com>, <seanjc@google.com>, <pbonzini@redhat.com>,
<nikunj@amd.com>
Subject: [PATCH v5 02/14] virt: sev-guest: Move mutex to SNP guest device structure
Date: Mon, 30 Oct 2023 12:06:40 +0530 [thread overview]
Message-ID: <20231030063652.68675-3-nikunj@amd.com> (raw)
In-Reply-To: <20231030063652.68675-1-nikunj@amd.com>
In preparation for providing a new API to the sev-guest driver for sending
an SNP guest message, move the SNP command mutex to the snp_guest_dev
structure.
Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
---
drivers/virt/coco/sev-guest/sev-guest.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/virt/coco/sev-guest/sev-guest.c b/drivers/virt/coco/sev-guest/sev-guest.c
index 68044c436866..85bda0c72a27 100644
--- a/drivers/virt/coco/sev-guest/sev-guest.c
+++ b/drivers/virt/coco/sev-guest/sev-guest.c
@@ -35,6 +35,9 @@ struct snp_guest_dev {
struct device *dev;
struct miscdevice misc;
+ /* Mutex to serialize the shared buffer access and command handling. */
+ struct mutex cmd_mutex;
+
void *certs_data;
struct aesgcm_ctx *ctx;
/* request and response are in unencrypted memory */
@@ -98,7 +101,7 @@ static inline u64 __snp_get_msg_seqno(struct snp_guest_dev *snp_dev)
{
u64 count;
- lockdep_assert_held(&snp_cmd_mutex);
+ lockdep_assert_held(&snp_dev->cmd_mutex);
/* Read the current message sequence counter from secrets pages */
count = *snp_dev->os_area_msg_seqno;
@@ -394,7 +397,7 @@ static int get_report(struct snp_guest_dev *snp_dev, struct snp_guest_request_io
struct snp_report_req req;
int rc, resp_len;
- lockdep_assert_held(&snp_cmd_mutex);
+ lockdep_assert_held(&snp_dev->cmd_mutex);
if (!arg->req_data || !arg->resp_data)
return -EINVAL;
@@ -434,7 +437,7 @@ static int get_derived_key(struct snp_guest_dev *snp_dev, struct snp_guest_reque
/* Response data is 64 bytes and max authsize for GCM is 16 bytes. */
u8 buf[64 + 16];
- lockdep_assert_held(&snp_cmd_mutex);
+ lockdep_assert_held(&snp_dev->cmd_mutex);
if (!arg->req_data || !arg->resp_data)
return -EINVAL;
@@ -472,7 +475,7 @@ static int get_ext_report(struct snp_guest_dev *snp_dev, struct snp_guest_reques
struct snp_report_resp *resp;
int ret, npages = 0, resp_len;
- lockdep_assert_held(&snp_cmd_mutex);
+ lockdep_assert_held(&snp_dev->cmd_mutex);
if (!arg->req_data || !arg->resp_data)
return -EINVAL;
@@ -557,12 +560,12 @@ static long snp_guest_ioctl(struct file *file, unsigned int ioctl, unsigned long
if (!input.msg_version)
return -EINVAL;
- mutex_lock(&snp_cmd_mutex);
+ mutex_lock(&snp_dev->cmd_mutex);
/* Check if the VMPCK is not empty */
if (is_vmpck_empty(snp_dev)) {
dev_err_ratelimited(snp_dev->dev, "VMPCK is disabled\n");
- mutex_unlock(&snp_cmd_mutex);
+ mutex_unlock(&snp_dev->cmd_mutex);
return -ENOTTY;
}
@@ -580,7 +583,7 @@ static long snp_guest_ioctl(struct file *file, unsigned int ioctl, unsigned long
break;
}
- mutex_unlock(&snp_cmd_mutex);
+ mutex_unlock(&snp_dev->cmd_mutex);
if (input.exitinfo2 && copy_to_user(argp, &input, sizeof(input)))
return -EFAULT;
@@ -699,6 +702,7 @@ static int __init sev_guest_probe(struct platform_device *pdev)
goto e_unmap;
}
+ mutex_init(&snp_dev->cmd_mutex);
platform_set_drvdata(pdev, snp_dev);
snp_dev->dev = dev;
snp_dev->layout = layout;
--
2.34.1
next prev parent reply other threads:[~2023-10-30 6:37 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 6:36 [PATCH v5 00/14] Add Secure TSC support for SNP guests Nikunj A Dadhania
2023-10-30 6:36 ` [PATCH v5 01/14] virt: sev-guest: Use AES GCM crypto library Nikunj A Dadhania
2023-10-30 17:51 ` Tom Lendacky
2023-11-02 3:33 ` Nikunj A. Dadhania
2023-10-30 6:36 ` Nikunj A Dadhania [this message]
2023-10-30 6:36 ` [PATCH v5 03/14] virt: sev-guest: Replace dev_dbg with pr_debug Nikunj A Dadhania
2023-10-30 6:36 ` [PATCH v5 04/14] virt: sev-guest: Add SNP guest request structure Nikunj A Dadhania
2023-10-30 18:16 ` Tom Lendacky
2023-11-02 4:01 ` Nikunj A. Dadhania
2023-10-30 6:36 ` [PATCH v5 05/14] virt: sev-guest: Add vmpck_id to snp_guest_dev struct Nikunj A Dadhania
2023-10-30 16:16 ` Dionna Amalie Glaze
2023-10-30 17:12 ` Tom Lendacky
2023-11-02 4:03 ` Nikunj A. Dadhania
2023-10-30 18:26 ` Tom Lendacky
2023-10-30 6:36 ` [PATCH v5 06/14] x86/sev: Cache the secrets page address Nikunj A Dadhania
2023-10-30 6:36 ` [PATCH v5 07/14] x86/sev: Move and reorganize sev guest request api Nikunj A Dadhania
2023-10-30 19:16 ` Tom Lendacky
2023-11-02 4:28 ` Nikunj A. Dadhania
2023-11-02 14:17 ` Tom Lendacky
2023-10-30 6:36 ` [PATCH v5 08/14] x86/mm: Add generic guest initialization hook Nikunj A Dadhania
2023-10-30 17:23 ` Dave Hansen
2023-11-02 4:30 ` Nikunj A. Dadhania
2023-10-30 19:19 ` Tom Lendacky
2023-11-02 5:08 ` Nikunj A. Dadhania
2023-10-30 6:36 ` [PATCH v5 09/14] x86/sev: Add Secure TSC support for SNP guests Nikunj A Dadhania
2023-10-30 16:46 ` Dionna Amalie Glaze
2023-11-02 5:13 ` Nikunj A. Dadhania
2023-10-30 20:26 ` Tom Lendacky
2023-11-02 5:36 ` Nikunj A. Dadhania
2023-11-02 14:29 ` Tom Lendacky
2023-11-02 5:41 ` Nikunj A. Dadhania
2023-11-02 10:36 ` Kirill A. Shutemov
2023-11-06 10:45 ` Nikunj A. Dadhania
2023-11-06 13:00 ` Kirill A. Shutemov
2023-10-30 6:36 ` [PATCH v5 10/14] x86/sev: Change TSC MSR behavior for Secure TSC enabled guests Nikunj A Dadhania
2023-10-30 6:36 ` [PATCH v5 11/14] x86/sev: Prevent RDTSC/RDTSCP interception " Nikunj A Dadhania
2023-10-30 20:32 ` Tom Lendacky
2023-11-02 5:47 ` Nikunj A. Dadhania
2023-10-30 6:36 ` [PATCH v5 12/14] x86/kvmclock: Skip kvmclock when Secure TSC is available Nikunj A Dadhania
2023-10-30 21:00 ` Tom Lendacky
2023-11-02 5:39 ` Nikunj A. Dadhania
2023-10-30 6:36 ` [PATCH v5 13/14] x86/tsc: Mark Secure TSC as reliable clocksource Nikunj A Dadhania
2023-10-30 17:18 ` Dave Hansen
2023-11-02 5:53 ` Nikunj A. Dadhania
2023-11-02 10:33 ` Kirill A. Shutemov
2023-11-02 12:07 ` Nikunj A. Dadhania
2023-11-02 12:16 ` Nikunj A. Dadhania
2023-11-02 12:38 ` Kirill A. Shutemov
2023-11-06 11:53 ` Nikunj A. Dadhania
2023-11-06 13:03 ` Kirill A. Shutemov
2023-10-30 6:36 ` [PATCH v5 14/14] x86/sev: Enable Secure TSC for SNP guests Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231030063652.68675-3-nikunj@amd.com \
--to=nikunj@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dionnaglaze@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pgonda@google.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox