From: Nico Boehr <nrb@linux.ibm.com>
To: frankja@linux.ibm.com, imbrenda@linux.ibm.com, thuth@redhat.com,
david@redhat.com, pbonzini@redhat.com, andrew.jones@linux.dev,
lvivier@redhat.com
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: [kvm-unit-tests PATCH v1 04/10] s390x: properly format non-kernel-doc comments
Date: Mon, 6 Nov 2023 13:51:00 +0100 [thread overview]
Message-ID: <20231106125352.859992-5-nrb@linux.ibm.com> (raw)
In-Reply-To: <20231106125352.859992-1-nrb@linux.ibm.com>
These comments do not follow the kernel-doc style, hence they should not
start with /**.
Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
---
s390x/sclp.c | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/s390x/sclp.c b/s390x/sclp.c
index 1abb9029f984..ccbaa9136fdb 100644
--- a/s390x/sclp.c
+++ b/s390x/sclp.c
@@ -32,7 +32,7 @@ static union {
} sccb_template;
static uint32_t valid_code; /* valid command code for READ SCP INFO */
-/**
+/*
* Perform one service call, handling exceptions and interrupts.
*/
static int sclp_service_call_test(unsigned int command, void *sccb)
@@ -51,7 +51,7 @@ static int sclp_service_call_test(unsigned int command, void *sccb)
return cc;
}
-/**
+/*
* Perform one test at the given address, optionally using the SCCB template,
* checking for the expected program interrupts and return codes.
*
@@ -96,7 +96,7 @@ static bool test_one_sccb(uint32_t cmd, uint8_t *addr, uint16_t buf_len, uint64_
return true;
}
-/**
+/*
* Wrapper for test_one_sccb to be used when the template should not be
* copied and the memory address should not be touched.
*/
@@ -105,7 +105,7 @@ static bool test_one_ro(uint32_t cmd, uint8_t *addr, uint64_t exp_pgm, uint16_t
return test_one_sccb(cmd, addr, 0, exp_pgm, exp_rc);
}
-/**
+/*
* Wrapper for test_one_sccb to set up a simple SCCB template.
*
* The parameter sccb_len indicates the value that will be saved in the SCCB
@@ -124,7 +124,7 @@ static bool test_one_simple(uint32_t cmd, uint8_t *addr, uint16_t sccb_len,
return test_one_sccb(cmd, addr, buf_len, exp_pgm, exp_rc);
}
-/**
+/*
* Test SCCB lengths < 8.
*/
static void test_sccb_too_short(void)
@@ -138,7 +138,7 @@ static void test_sccb_too_short(void)
report(len == 8, "SCCB too short");
}
-/**
+/*
* Test SCCBs that are not 64-bit aligned.
*/
static void test_sccb_unaligned(void)
@@ -151,7 +151,7 @@ static void test_sccb_unaligned(void)
report(offset == 8, "SCCB unaligned");
}
-/**
+/*
* Test SCCBs whose address is in the lowcore or prefix area.
*/
static void test_sccb_prefix(void)
@@ -202,7 +202,7 @@ static void test_sccb_prefix(void)
set_prefix(prefix);
}
-/**
+/*
* Test SCCBs that are above 2GB. If outside of memory, an addressing
* exception is also allowed.
*/
@@ -245,7 +245,7 @@ static void test_sccb_high(void)
report(i == len, "SCCB high addresses");
}
-/**
+/*
* Test invalid commands, both invalid command detail codes and valid
* ones with invalid command class code.
*/
@@ -275,7 +275,7 @@ static void test_inval(void)
}
-/**
+/*
* Test short SCCBs (but larger than 8).
*/
static void test_short(void)
@@ -294,7 +294,7 @@ static void test_short(void)
report(len == 40, "Insufficient SCCB length (Read CPU info)");
}
-/**
+/*
* Test SCCB page boundary violations.
*/
static void test_boundary(void)
@@ -318,7 +318,7 @@ out:
report(len > 4096 && offset == 4096, "SCCB page boundary violation");
}
-/**
+/*
* Test excessively long SCCBs.
*/
static void test_toolong(void)
@@ -338,7 +338,7 @@ static void test_toolong(void)
report(len == 8192, "SCCB bigger than 4k");
}
-/**
+/*
* Test privileged operation.
*/
static void test_priv(void)
@@ -354,7 +354,7 @@ static void test_priv(void)
report_prefix_pop();
}
-/**
+/*
* Test addressing exceptions. We need to test SCCB addresses between the
* end of available memory and 2GB, because after 2GB a specification
* exception is also allowed.
@@ -393,7 +393,7 @@ out:
report(i + maxram >= 0x80000000, "Invalid SCCB address");
}
-/**
+/*
* Test some bits in the instruction format that are specified to be ignored.
*/
static void test_instbits(void)
@@ -422,7 +422,7 @@ static void test_instbits(void)
report(cc == 0, "Instruction format ignored bits");
}
-/**
+/*
* Find a valid READ INFO command code; not all codes are always allowed, and
* probing should be performed in the right order.
*/
--
2.41.0
next prev parent reply other threads:[~2023-11-06 12:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 12:50 [kvm-unit-tests PATCH v1 00/10] RFC: Add clang-format and kerneldoc check Nico Boehr
2023-11-06 12:50 ` [kvm-unit-tests PATCH v1 01/10] make: add target to check kernel-doc comments Nico Boehr
2023-11-22 12:27 ` Thomas Huth
2023-11-06 12:50 ` [kvm-unit-tests PATCH v1 02/10] powerpc: properly format non-kernel-doc comments Nico Boehr
2023-11-06 16:53 ` Claudio Imbrenda
2023-11-06 17:13 ` Nico Boehr
2023-11-07 8:37 ` Thomas Huth
2023-11-07 18:42 ` Claudio Imbrenda
2023-11-22 12:28 ` Thomas Huth
2023-11-06 12:50 ` [kvm-unit-tests PATCH v1 03/10] lib: s390x: cpacf: move kernel-doc comment to correct function Nico Boehr
2023-11-22 12:47 ` Thomas Huth
2023-11-06 12:51 ` Nico Boehr [this message]
2023-11-06 16:54 ` [kvm-unit-tests PATCH v1 04/10] s390x: properly format non-kernel-doc comments Claudio Imbrenda
2023-11-22 12:47 ` Thomas Huth
2023-11-06 12:51 ` [kvm-unit-tests PATCH v1 05/10] s390x: ensure kernel-doc parameters are properly formated Nico Boehr
2023-11-22 12:49 ` Thomas Huth
2023-11-06 12:51 ` [kvm-unit-tests PATCH v1 06/10] x86: properly format non-kernel-doc comments Nico Boehr
2023-11-22 12:49 ` Thomas Huth
2023-11-06 12:51 ` [kvm-unit-tests PATCH v1 07/10] s390x: cpumodel: list tcg_fail explicitly Nico Boehr
2023-11-06 12:51 ` [kvm-unit-tests PATCH v1 08/10] s390x: gs: turn off formatter for inline assembly Nico Boehr
2023-11-06 12:51 ` [kvm-unit-tests PATCH v1 09/10] add clang-format configuration file Nico Boehr
2023-11-22 12:56 ` Thomas Huth
2023-11-06 12:51 ` [kvm-unit-tests PATCH v1 10/10] add make format Nico Boehr
2023-11-22 13:09 ` [kvm-unit-tests PATCH v1 00/10] RFC: Add clang-format and kerneldoc check Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231106125352.859992-5-nrb@linux.ibm.com \
--to=nrb@linux.ibm.com \
--cc=andrew.jones@linux.dev \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox