RE: [PATCH v3 1/6] target/i386: add support for FRED in CPUID enumeration

Li, Xin3
2023-12-21T08:27:18Z

>> @@ -1552,6 +1552,14 @@ static FeatureDep feature_dependencies[] = {
>> .from = { FEAT_VMX_SECONDARY_CTLS, VMX_SECONDARY_EXEC_ENABLE_USER_WAIT_PAUSE },
>> .to = { FEAT_7_0_ECX, CPUID_7_0_ECX_WAITPKG },
>> },
>> + {
>> + .from = { FEAT_7_1_EAX, CPUID_7_1_EAX_FRED },
>> + .to = { FEAT_7_1_EAX, CPUID_7_1_EAX_LKGS },
>> + },
>> + {
>> + .from = { FEAT_7_1_EAX, CPUID_7_1_EAX_FRED },
>> + .to = { FEAT_7_1_EAX, CPUID_7_1_EAX_WRMSRNS },
>> + },
>
> since FRED relies on LKGS and WRMSRNS, here should be as follow:
>

You're right, I messed it up in this version.
Thank!
Xin

> + {
> + .from = { FEAT_7_1_EAX, CPUID_7_1_EAX_LKGS },
> + .to = { FEAT_7_1_EAX, CPUID_7_1_EAX_FRED },
> + },
> + {
> + .from = { FEAT_7_1_EAX, CPUID_7_1_EAX_WRMSRNS },
> + .to = { FEAT_7_1_EAX, CPUID_7_1_EAX_FRED },
> + },