Re: [PATCH V4 vfio 4/9] virtio-pci: Introduce admin commands

Michael S. Tsirkin
2023-11-30T09:52:41Z

On Wed, Nov 29, 2023 at 04:37:41PM +0200, Yishai Hadas wrote:
> +/* Transitional device admin command. */
> +#define VIRTIO_ADMIN_CMD_LEGACY_COMMON_CFG_WRITE 0x2
> +#define VIRTIO_ADMIN_CMD_LEGACY_COMMON_CFG_READ 0x3
> +#define VIRTIO_ADMIN_CMD_LEGACY_DEV_CFG_WRITE 0x4
> +#define VIRTIO_ADMIN_CMD_LEGACY_DEV_CFG_READ 0x5
> +#define VIRTIO_ADMIN_CMD_LEGACY_NOTIFY_INFO 0x6
> +
> +/* Increment MAX_OPCODE to next value when new opcode is added */
> +#define VIRTIO_ADMIN_MAX_CMD_OPCODE 0x6

Does anything need VIRTIO_ADMIN_MAX_CMD_OPCODE? Not in this
patchset...

--
MST