From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Gp7oj5Tu" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1F7E1710 for ; Thu, 30 Nov 2023 12:36:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701376598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eYEi0Y5+QQuaOwHuJk++/9L4d3OIIjWT68mwc8kKwmY=; b=Gp7oj5Tu7hEk2Ut+/07sBPKIO8SvmmfikxWc8WmLDmdu4LuiDajWPwHQ0NhP9nV9fQTEfK 9gn4I3oK5sC8SSOiz5VfuWG8BcKUSm9T6zBBLDyUq/W8FLv2Od5L54P20Wj7hNKkKrljgY 4y4qfKacCi4ZboOALtqLwmONxn6blRM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-422-02OrGnDnMu2lEKHvHbc0dA-1; Thu, 30 Nov 2023 15:36:36 -0500 X-MC-Unique: 02OrGnDnMu2lEKHvHbc0dA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F38B78058F0; Thu, 30 Nov 2023 20:36:35 +0000 (UTC) Received: from localhost (unknown [10.39.192.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7B9DD2166B26; Thu, 30 Nov 2023 20:36:34 +0000 (UTC) Date: Thu, 30 Nov 2023 15:36:33 -0500 From: Stefan Hajnoczi To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Jean-Christophe Dubois , Fabiano Rosas , qemu-s390x@nongnu.org, Song Gao , Marcel Apfelbaum , Thomas Huth , Hyman Huang , Marcelo Tosatti , David Woodhouse , Andrey Smirnov , Peter Maydell , Kevin Wolf , Ilya Leoshkevich , Artyom Tarasenko , Mark Cave-Ayland , Max Filippov , Alistair Francis , Paul Durrant , Jagannathan Raman , Juan Quintela , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , qemu-arm@nongnu.org, Jason Wang , Gerd Hoffmann , Hanna Reitz , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , BALATON Zoltan , Daniel Henrique Barboza , Elena Ufimtseva , Aurelien Jarno , Hailiang Zhang , Roman Bolshakov , Huacai Chen , Fam Zheng , Eric Blake , Jiri Slaby , Alexander Graf , Liu Zhiwei , Weiwei Li , Eric Farman , Stafford Horne , David Hildenbrand , Markus Armbruster , Reinoud Zandijk , Palmer Dabbelt , Cameron Esfahani , xen-devel@lists.xenproject.org, Pavel Dovgalyuk , qemu-riscv@nongnu.org, Aleksandar Rikalo , John Snow , Sunil Muthuswamy , Michael Roth , David Gibson , "Michael S. Tsirkin" , Richard Henderson , Bin Meng , Stefano Stabellini , kvm@vger.kernel.org, qemu-block@nongnu.org, Halil Pasic , Peter Xu , Anthony Perard , Harsh Prateek Bora , Alex =?iso-8859-1?Q?Benn=E9e?= , Eduardo Habkost , Paolo Bonzini , Vladimir Sementsov-Ogievskiy , =?iso-8859-1?Q?C=E9dric?= Le Goater , qemu-ppc@nongnu.org, Christian Borntraeger , Akihiko Odaki , Leonardo Bras , Nicholas Piggin , Jiaxun Yang Subject: Re: [PATCH 5/6] Replace "iothread lock" with "BQL" in comments Message-ID: <20231130203633.GC1184658@fedora> References: <20231129212625.1051502-1-stefanha@redhat.com> <20231129212625.1051502-6-stefanha@redhat.com> <9c305a84-fd86-42fe-98ae-9297d480acd6@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ADMBXqBOX1KM7dkn" Content-Disposition: inline In-Reply-To: <9c305a84-fd86-42fe-98ae-9297d480acd6@linaro.org> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 --ADMBXqBOX1KM7dkn Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 30, 2023 at 02:47:49PM +0100, Philippe Mathieu-Daud=E9 wrote: > Hi Stefan, >=20 > On 29/11/23 22:26, Stefan Hajnoczi wrote: > > The term "iothread lock" is obsolete. The APIs use Big QEMU Lock (BQL) > > in their names. Update the code comments to use "BQL" instead of > > "iothread lock". > >=20 > > Signed-off-by: Stefan Hajnoczi > > --- > > docs/devel/reset.rst | 2 +- > > hw/display/qxl.h | 2 +- > > include/exec/cpu-common.h | 2 +- > > include/exec/memory.h | 4 ++-- > > include/exec/ramblock.h | 2 +- > > include/migration/register.h | 8 ++++---- > > target/arm/internals.h | 4 ++-- > > accel/tcg/cputlb.c | 4 ++-- > > accel/tcg/tcg-accel-ops-icount.c | 2 +- > > hw/remote/mpqemu-link.c | 2 +- > > migration/block-dirty-bitmap.c | 10 +++++----- > > migration/block.c | 24 ++++++++++++------------ > > migration/colo.c | 2 +- > > migration/migration.c | 2 +- > > migration/ram.c | 4 ++-- > > system/physmem.c | 6 +++--- > > target/arm/helper.c | 2 +- > > target/arm/tcg/m_helper.c | 2 +- > > ui/spice-core.c | 2 +- > > util/rcu.c | 2 +- > > audio/coreaudio.m | 4 ++-- > > ui/cocoa.m | 6 +++--- > > 22 files changed, 49 insertions(+), 49 deletions(-) >=20 >=20 > > diff --git a/include/exec/ramblock.h b/include/exec/ramblock.h > > index 69c6a53902..a2bc0a345d 100644 > > --- a/include/exec/ramblock.h > > +++ b/include/exec/ramblock.h > > @@ -34,7 +34,7 @@ struct RAMBlock { > > ram_addr_t max_length; > > void (*resized)(const char*, uint64_t length, void *host); > > uint32_t flags; > > - /* Protected by iothread lock. */ > > + /* Protected by BQL. */ >=20 > There is only one single BQL, so preferably: >=20 > "by the BQL" >=20 > > char idstr[256]; > > /* RCU-enabled, writes protected by the ramlist lock */ > > QLIST_ENTRY(RAMBlock) next; >=20 >=20 >=20 >=20 > > -/* Called with iothread lock taken. */ > > +/* Called with BQL taken. */ >=20 > "with the BQL" (other uses) I will try to change these for v2. It's a pre-existing issue though because there was only ever one "iothread lock" too. Stefan --ADMBXqBOX1KM7dkn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmVo8lEACgkQnKSrs4Gr c8inmQf8CHG08Gjf/Xbq1d507Sf6BOzXT42zcBsMdkGeul6WorzG8oHfr1SMVJgi Fkex2GIeIAH3TjLTtiXePxp/7MXVrArmRxUltKaaZZAcD48aA8VXeOylS3pnZnU+ 2cqukgamf6tOSIc43sr1ZX06y154qL7xAMQ8Xl0sUu3ERaJob0bzyfPKf2xgjnas wVfsXUS7nEcRMJVi94oT9ST1WpJPbA9yDVyVX3LwtX0KECWoYIiN9or7jTlP2TnA 9/GXVa9I8R/eA0P2xLU2RpfNNNY9A9+MZvgHSU75u9C9jN4/CR59W8EjyBTl+/fA KHaDBsL7B4GbwgONA8VDLiAbIN/g3Q== =Ause -----END PGP SIGNATURE----- --ADMBXqBOX1KM7dkn--