From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="OWpNbHY0" Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 583CFA0 for ; Fri, 1 Dec 2023 01:26:20 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40b27b498c3so19725035e9.0 for ; Fri, 01 Dec 2023 01:26:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1701422779; x=1702027579; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bjnUIjZvPfyuyaADWQAn6lsAbXJm4+j0sZmUamispe8=; b=OWpNbHY0FUpRYTbYrSygzSbCao+y54Bs2lrUt9XCKsdY9ZZaDpC1SafnCe+Hxcp2Jy 0nPuDdeYirFjD5EpHxjnEvTEL1FgKv9XQY680sDedQnj3+XCf7EcDQXR+TujDX51BkW4 ycPYcdpXHFJ3m81/uVkdyI7/maawh2xtx7qFWKFaV4gLXJCQ+mnoeFExTL2pFILvytSH JxptHNkutd8tEQSsJQgT1uI1N7VTLgCzl4Nm9xQGO4F2oxCZ8ac60nASJGJ5JLd89mc5 kccYiRvdNIZTihqdkv5WAlK77BB6oSM1ZfqG3cDO7cK6CcIzDhX4GJzPyNMoyhZ+kGn8 6qvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701422779; x=1702027579; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bjnUIjZvPfyuyaADWQAn6lsAbXJm4+j0sZmUamispe8=; b=WAmRGRppXHgF/XcdpXiSd7E6WIEcmghExIujaBtLHkVLhz3z/jxig2KlJ2jpGrNhb1 Eu5ha50kw5zve7GT6epPqUiYCTNyBk9Z2bNpxE2IPBCfSZzBZ0y2O0gJsEk1IzJ18ajP wxWl90SXKt2qZZvVX/EtZycUDiIc6/NILd6qME2FHhROQIQ1eyZO95hgeC6b4biekEM/ HOoO8G04wjfpZhuxzN8s5Vc24vMSuKLLUTM3hbRJXMw5rkgf521oKOUpjQOfJwpNSEzi fRVxpETvd21DcnXZexLodq3/7GqQK00TES+uoLiTmd8x2iSm0ap9b47nkESzLb1Tl/F7 JBzQ== X-Gm-Message-State: AOJu0Yxk+5rS53igWUgSEFv+WOIgFPPxEYfke1AZuJIy8kVZa7+yWDNq ewG386hgmPQxFPycmsPkzkgkFQ== X-Google-Smtp-Source: AGHT+IFqzSTcoNxST3FhOHCG+Us/Epbb855+4fIW887wnW7kaEu5A+g3d/FtOLxG6on8h/bTU+QRLA== X-Received: by 2002:a05:600c:4709:b0:40b:5e1d:83a3 with SMTP id v9-20020a05600c470900b0040b5e1d83a3mr297560wmo.55.1701422778732; Fri, 01 Dec 2023 01:26:18 -0800 (PST) Received: from localhost (cst2-173-16.cust.vodafone.cz. [31.30.173.16]) by smtp.gmail.com with ESMTPSA id bi19-20020a05600c3d9300b0040b54d7ebb9sm4688580wmb.41.2023.12.01.01.26.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 01:26:18 -0800 (PST) Date: Fri, 1 Dec 2023 10:26:17 +0100 From: Andrew Jones To: Sean Christopherson Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, maz@kernel.org, oliver.upton@linux.dev Subject: Re: [PATCH] KVM: selftests: Drop newline from __TEST_REQUIRE Message-ID: <20231201-08a259a1ef0bd02eba0c550d@orel> References: <20231130182832.54603-2-ajones@ventanamicro.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Nov 30, 2023 at 07:16:28PM +0000, Sean Christopherson wrote: > On Thu, Nov 30, 2023, Andrew Jones wrote: > > A few __TEST_REQUIRE callers are appending their own newline, resulting > > in an extra one being output. Rather than remove the newlines from > > those callers, remove it from __TEST_REQUIRE and add newlines to all > > the other callers, as __TEST_REQUIRE was the only output function > > appending newlines and consistency is a good thing. > > > > Signed-off-by: Andrew Jones > > --- > > > > Applies to kvm-x86/selftests (I chose that branch to ensure I got the > > MAGIC_TOKEN change) > > Heh, and then I went and created a conflict anyways :-) > > https://lore.kernel.org/all/20231129224042.530798-1-seanjc@google.com > > If there are no objections, I'll grab this in kvm-x86/selftests and sort out the > MAGIC_TOKEN conflict. No objections from me. Thanks, drew