Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Andrew Jones <ajones@ventanamicro.com>
To: kvm@vger.kernel.org, kvmarm@lists.linux.dev,
	 kvm-riscv@lists.infradead.org
Cc: seanjc@google.com, pbonzini@redhat.com, maz@kernel.org,
	 oliver.upton@linux.dev, anup@brainfault.org,
	borntraeger@linux.ibm.com,  frankja@linux.ibm.com,
	imbrenda@linux.ibm.com
Subject: Re: [PATCH 0/5] KVM: selftests: Remove redundant newlines
Date: Wed, 6 Dec 2023 18:07:37 +0100	[thread overview]
Message-ID: <20231206-6c869e5bc8ddf3b93e5b6fd6@orel> (raw)
In-Reply-To: <20231206170241.82801-7-ajones@ventanamicro.com>

On Wed, Dec 06, 2023 at 06:02:42PM +0100, Andrew Jones wrote:
> This series has a lot of churn for dubious value, but I'm posting it
> anyway since I've already done the work. Each patch in the series is
> simply removing trailing newlines from format strings in TEST_* function
> callsites, since TEST_* functions append their own. The first patch
> addresses common lib and test code, the rest of the changes are split
> by arch in the remaining patches.
> 
> Figuring out which newlines to delete was done with a long, ugly
> grep regular expression[*] and then highlighting '\n' in the output
> and manually skimming to find, and then manually fix, each instance.
> I'm sure there's some AI tool that would have done everything for me,
> but this was my chance to prove I'm still as capable as AI (well,
> unless I missed some...)
> 
> [*] grep -rn . tools/testing/selftests/kvm |
>     grep -Pzo '(?s)\n[^\n]*TEST_(ASSERT|REQUIRE|FAIL)\(.*?\)\s*;' |
>     tr '\0' '\n'
> 
> 
> Andrew Jones (5):
>   KVM: selftests: Remove redundant newlines
>   KVM: selftests: aarch64: Remove redundant newlines
>   KVM: selftests: riscv: Remove redundant newlines
>   KVM: selftests: s390x: Remove redundant newlines
>   KVM: selftests: x86_64: Remove redundant newlines
>

I forgot to mention that this series is based on kvm-x86/selftests.

Thanks,
drew

  parent reply	other threads:[~2023-12-06 17:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-06 17:02 [PATCH 0/5] KVM: selftests: Remove redundant newlines Andrew Jones
2023-12-06 17:02 ` [PATCH 1/5] " Andrew Jones
2023-12-06 17:02 ` [PATCH 2/5] KVM: selftests: aarch64: " Andrew Jones
2023-12-07 11:19   ` Zenghui Yu
2023-12-06 17:02 ` [PATCH 3/5] KVM: selftests: riscv: " Andrew Jones
2023-12-07  3:36   ` Anup Patel
2023-12-06 17:02 ` [PATCH 4/5] KVM: selftests: s390x: " Andrew Jones
2023-12-06 17:09   ` Claudio Imbrenda
2023-12-06 17:18   ` Janosch Frank
2023-12-06 17:02 ` [PATCH 5/5] KVM: selftests: x86_64: " Andrew Jones
2024-01-30 20:26   ` Sean Christopherson
2024-01-31  8:49     ` Andrew Jones
2023-12-06 17:07 ` Andrew Jones [this message]
2024-01-31  0:59 ` [PATCH 0/5] KVM: selftests: " Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231206-6c869e5bc8ddf3b93e5b6fd6@orel \
    --to=ajones@ventanamicro.com \
    --cc=anup@brainfault.org \
    --cc=borntraeger@linux.ibm.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm-riscv@lists.infradead.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox