Re: [kvm-unit-tests PATCH 1/5] lib: Add pseudo random functions

Andrew Jones
2023-12-13T17:53:56Z

On Wed, Dec 13, 2023 at 06:43:51PM +0100, Nina Schoetterl-Glausch wrote:
> On Wed, 2023-12-13 at 14:38 +0100, Andrew Jones wrote:
> > On Wed, Dec 13, 2023 at 01:49:38PM +0100, Nina Schoetterl-Glausch wrote:
> > > Add functions for generating pseudo random 32 and 64 bit values.
> > > The implementation is very simple and the randomness likely not
> > > of high quality.
>
> [...]
>
> > Alex Bennée posted a prng patch a long time ago that never got merged.
> >
> > https://www.spinics.net/lists/kvm-arm/msg50921.html
> >
> > would it be better to merge that?
>
> Well, it's hard to say what metric to apply here.
> How good does the randomness need to be?

Better randomness would improve coverage for random sample set type tests
and possibly help stress more for stress tests.

> I chose a minimal interface that should be amendable to evolution.
> That's why the state is hidden behind a typedef.
> I think this would be good for Alex' patch, too, and there is nothing gained
> by exposing the implementation by prefixing everything with isaac.

I agree.

> My patch is also simpler to review.
> But I'm certainly not opposed to better algorithms.

Do you mind reposting Alex's patch, maintaining his authorship, but with
your interface changes?

Thanks,
drew