From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: Yi Liu <yi.l.liu@intel.com>,
joro@8bytes.org, alex.williamson@redhat.com,
kevin.tian@intel.com, robin.murphy@arm.com,
baolu.lu@linux.intel.com, cohuck@redhat.com,
eric.auger@redhat.com, kvm@vger.kernel.org,
mjrosato@linux.ibm.com, chao.p.peng@linux.intel.com,
yi.y.sun@linux.intel.com, peterx@redhat.com, jasowang@redhat.com,
shameerali.kolothum.thodi@huawei.com, lulu@redhat.com,
suravee.suthikulpanit@amd.com, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
zhenzhong.duan@intel.com, joao.m.martins@oracle.com,
xin.zeng@intel.com, yan.y.zhao@intel.com, j.granados@samsung.com,
binbin.wu@linux.intel.com
Subject: Re: [PATCH v11 6/8] iommufd/selftest: Add coverage for IOMMU_HWPT_INVALIDATE ioctl
Date: Thu, 11 Jan 2024 12:54:35 -0400 [thread overview]
Message-ID: <20240111165435.GJ439767@nvidia.com> (raw)
In-Reply-To: <ZaAcZXrhhQPhKTHq@Asurada-Nvidia>
On Thu, Jan 11, 2024 at 08:50:45AM -0800, Nicolin Chen wrote:
> On Wed, Jan 10, 2024 at 08:10:13PM -0800, Yi Liu wrote:
> > +#define test_cmd_hwpt_invalidate(hwpt_id, reqs, data_type, lreq, nreqs) \
> > + ({ \
> > + ASSERT_EQ(0, \
> > + _test_cmd_hwpt_invalidate(self->fd, hwpt_id, reqs, \
> > + data_type, \
> > + lreq, nreqs)); \
> > + })
> > +#define test_err_hwpt_invalidate(_errno, hwpt_id, reqs, data_type, lreq, \
> > + nreqs) \
> > + ({ \
> > + EXPECT_ERRNO(_errno, \
> > + _test_cmd_hwpt_invalidate(self->fd, hwpt_id, \
> > + reqs, data_type, \
> > + lreq, nreqs)); \
> > + })
>
> Nit: spaces at the end of the four lines above that have string
> "data_type" are all misaligned, probably because of the previous
> replacement of "req_type".
I will fix it
Jason
next prev parent reply other threads:[~2024-01-11 16:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 4:10 [PATCH v11 0/8] Add iommufd nesting (part 2/2) Yi Liu
2024-01-11 4:10 ` [PATCH v11 1/8] iommu: Add cache_invalidate_user op Yi Liu
2024-01-11 4:10 ` [PATCH v11 2/8] iommufd: Add IOMMU_HWPT_INVALIDATE Yi Liu
2024-01-11 4:10 ` [PATCH v11 3/8] iommu: Add iommu_copy_struct_from_user_array helper Yi Liu
2024-01-11 16:55 ` Nicolin Chen
2024-01-11 4:10 ` [PATCH v11 4/8] iommufd/selftest: Add mock_domain_cache_invalidate_user support Yi Liu
2024-01-11 4:10 ` [PATCH v11 5/8] iommufd/selftest: Add IOMMU_TEST_OP_MD_CHECK_IOTLB test op Yi Liu
2024-01-11 4:10 ` [PATCH v11 6/8] iommufd/selftest: Add coverage for IOMMU_HWPT_INVALIDATE ioctl Yi Liu
2024-01-11 16:50 ` Nicolin Chen
2024-01-11 16:54 ` Jason Gunthorpe [this message]
2024-01-11 4:10 ` [PATCH v11 7/8] iommufd: Add data structure for Intel VT-d stage-1 cache invalidation Yi Liu
2024-01-11 4:10 ` [PATCH v11 8/8] iommu/vt-d: Add iotlb flush for nested domain Yi Liu
2024-01-11 5:51 ` [PATCH v11 0/8] Add iommufd nesting (part 2/2) Tian, Kevin
2024-01-11 19:56 ` Jason Gunthorpe
2024-01-16 3:03 ` Duan, Zhenzhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240111165435.GJ439767@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=binbin.wu@linux.intel.com \
--cc=chao.p.peng@linux.intel.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=j.granados@samsung.com \
--cc=jasowang@redhat.com \
--cc=joao.m.martins@oracle.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=peterx@redhat.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xin.zeng@intel.com \
--cc=yan.y.zhao@intel.com \
--cc=yi.l.liu@intel.com \
--cc=yi.y.sun@linux.intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox