From: Andrew Jones <andrew.jones@linux.dev>
To: Shaoqin Huang <shahuang@redhat.com>
Cc: kvmarm@lists.linux.dev, Thomas Huth <thuth@redhat.com>,
Nico Boehr <nrb@linux.ibm.com>,
Colton Lewis <coltonlewis@google.com>,
Nina Schoetterl-Glausch <nsg@linux.ibm.com>,
Nikos Nikoleris <nikos.nikoleris@arm.com>,
kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v2 2/3] runtime: arm64: Skip the migration tests when run on EFI
Date: Mon, 15 Jan 2024 13:25:42 +0100 [thread overview]
Message-ID: <20240115-92ecda86253ec8b52f348eda@orel> (raw)
In-Reply-To: <20231130032940.2729006-3-shahuang@redhat.com>
On Wed, Nov 29, 2023 at 10:29:39PM -0500, Shaoqin Huang wrote:
> When running the migration tests on EFI, the migration will always fail
> since the efi/run use the vvfat format to run test, but the vvfat format
> does not support live migration. So those migration tests will always
> fail.
>
> Instead of waiting for fail everytime when run migration tests on EFI,
> skip those tests if running on EFI.
>
> Signed-off-by: Shaoqin Huang <shahuang@redhat.com>
> ---
> scripts/runtime.bash | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/scripts/runtime.bash b/scripts/runtime.bash
> index c73fb024..64d223e8 100644
> --- a/scripts/runtime.bash
> +++ b/scripts/runtime.bash
> @@ -156,6 +156,10 @@ function run()
>
> cmdline=$(get_cmdline $kernel)
> if find_word "migration" "$groups"; then
> + if [ "{CONFIG_EFI}" == "y" ]; then
> + print_result "SKIP" $testname "" "migration tests are not supported with efi"
> + return 2
> + fi
> cmdline="MIGRATION=yes $cmdline"
> fi
> if find_word "panic" "$groups"; then
> --
> 2.40.1
>
This isn't arm-specific, so we should drop the arm64 prefix from the patch
summary and get an ack from x86 people.
Thanks,
drew
next prev parent reply other threads:[~2024-01-15 12:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 3:29 [kvm-unit-tests PATCH v2 0/3] arm64: runtime scripts improvements on efi Shaoqin Huang
2023-11-30 3:29 ` [kvm-unit-tests PATCH v2 1/3] runtime: Fix the missing last_line Shaoqin Huang
2024-01-15 12:26 ` Andrew Jones
2023-11-30 3:29 ` [kvm-unit-tests PATCH v2 2/3] runtime: arm64: Skip the migration tests when run on EFI Shaoqin Huang
2023-11-30 4:17 ` Shaoqin Huang
2024-01-15 12:25 ` Andrew Jones [this message]
2024-01-16 6:19 ` Shaoqin Huang
2023-11-30 3:29 ` [kvm-unit-tests PATCH v2 3/3] arm64: efi: Make running tests on EFI can be parallel Shaoqin Huang
2024-01-15 12:23 ` Andrew Jones
2024-01-16 6:37 ` Shaoqin Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240115-92ecda86253ec8b52f348eda@orel \
--to=andrew.jones@linux.dev \
--cc=coltonlewis@google.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=nikos.nikoleris@arm.com \
--cc=nrb@linux.ibm.com \
--cc=nsg@linux.ibm.com \
--cc=shahuang@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox