From: Yi Wang <up2wing@gmail.com>
To: seanjc@google.com, pbonzini@redhat.com, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, wanpengli@tencent.com,
foxywang@tencent.com, oliver.upton@linux.dev, maz@kernel.org,
anup@brainfault.org, atishp@atishpatra.org,
borntraeger@linux.ibm.com, frankja@linux.ibm.com,
imbrenda@linux.ibm.com
Cc: up2wing@gmail.com
Subject: [v2 4/4] KVM: s390: don't setup dummy routing when KVM_CREATE_IRQCHIP
Date: Sun, 21 Jan 2024 19:17:30 +0800 [thread overview]
Message-ID: <20240121111730.262429-5-foxywang@tencent.com> (raw)
In-Reply-To: <20240121111730.262429-1-foxywang@tencent.com>
As we have setup empty irq routing in kvm_create_vm(), there's
no need to setup dummy routing when KVM_CREATE_IRQCHIP.
Signed-off-by: Yi Wang <foxywang@tencent.com>
---
arch/s390/kvm/kvm-s390.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index acc81ca6492e..7c836c973b75 100644
--- a/arch/s390/kvm/kvm-s390.c
+++ b/arch/s390/kvm/kvm-s390.c
@@ -2999,14 +2999,11 @@ int kvm_arch_vm_ioctl(struct file *filp, unsigned int ioctl, unsigned long arg)
break;
}
case KVM_CREATE_IRQCHIP: {
- struct kvm_irq_routing_entry routing;
-
- r = -EINVAL;
- if (kvm->arch.use_irqchip) {
- /* Set up dummy routing. */
- memset(&routing, 0, sizeof(routing));
- r = kvm_set_irq_routing(kvm, &routing, 0, 0);
- }
+ /*
+ * As we have set up empty routing, there is no need to
+ * setup dummy routing here.
+ */
+ r = 0;
break;
}
case KVM_SET_DEVICE_ATTR: {
--
2.39.3
next prev parent reply other threads:[~2024-01-21 11:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-21 11:17 [v2 0/4] KVM: irqchip: synchronize srcu only if needed Yi Wang
2024-01-21 11:17 ` [v2 1/4] KVM: irqchip: add setup empty irq routing function Yi Wang
2024-01-23 18:47 ` Oliver Upton
2024-01-24 2:12 ` Yi Wang
2024-01-21 11:17 ` [v2 2/4] KVM: setup empty irq routing when create vm Yi Wang
2024-01-21 11:17 ` [v2 3/4] KVM: x86: don't setup empty irq routing when KVM_CAP_SPLIT_IRQCHIP Yi Wang
2024-01-21 11:17 ` Yi Wang [this message]
2024-01-23 18:54 ` [v2 4/4] KVM: s390: don't setup dummy routing when KVM_CREATE_IRQCHIP Oliver Upton
2024-01-24 2:16 ` Yi Wang
2024-01-24 12:14 ` [v2 0/4] KVM: irqchip: synchronize srcu only if needed Christian Borntraeger
2024-01-24 12:44 ` Yi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240121111730.262429-5-foxywang@tencent.com \
--to=up2wing@gmail.com \
--cc=anup@brainfault.org \
--cc=atishp@atishpatra.org \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=foxywang@tencent.com \
--cc=frankja@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox