Re: [PATCH v10 01/16] iommu: Move iommu fault data to linux/iommu.h

Jason Gunthorpe
2024-01-25T13:43:39Z

On Thu, Jan 25, 2024 at 10:17:34AM +0100, Joel Granados wrote:
> On Mon, Jan 22, 2024 at 01:42:53PM +0800, Lu Baolu wrote:
> > The iommu fault data is currently defined in uapi/linux/iommu.h, but is
> > only used inside the iommu subsystem. Move it to linux/iommu.h, where it
> > will be more accessible to kernel drivers.
> >
> > With this done, uapi/linux/iommu.h becomes empty and can be removed from
> > the tree.
>
> The reason for removing this [1] is that it is only being used by
> internal code in the kernel. What happens with usespace code that have
> used these definitions? Should we deprecate instead of just removing?

There was never an in-tree kernel implementation. Any userspace that
implemented this needs to decide on its own if it will continue to
support the non-mainline kernel and provide a copy of the definitions
itself..

(it was a process mistake to merge a uapi header without a
corresponding uapi implementation, sorry)

Jason