Re: [PATCH v9 05/27] x86/fpu/xstate: Introduce fpu_guest_cfg for guest FPU configuration

Yang, Weijiang
2024-01-30T15:00:48Z

On 1/30/2024 9:29 AM, Edgecombe, Rick P wrote:
> On Tue, 2024-01-23 at 18:41 -0800, Yang Weijiang wrote:
>> Define new fpu_guest_cfg to hold all guest FPU settings so that it
>> can
>> differ from generic kernel FPU settings, e.g., enabling CET
>> supervisor
>> xstate by default for guest fpstate while it's remained disabled in
>> kernel FPU config.
>>
>> The kernel dynamic xfeatures are specifically used by guest fpstate
>> now,
>> add the mask for guest fpstate so that guest_perm.__state_permit ==
> I think you mean 'guest_perm.__state_perm'.

Yes, will change it, thanks!

>
> Otherwise:
> Reviewed-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
>
>