Re: [PATCH v2 10/25] x86/sev: Add helper functions for RMPUPDATE and PSMASH instruction

Borislav Petkov
2024-01-29T19:34:27Z

On Mon, Jan 29, 2024 at 08:28:20PM +0100, Borislav Petkov wrote:
> On Mon, Jan 29, 2024 at 06:00:36PM +0000, Liam Merwick wrote:
> > asid is typically a u32 (or at least unsigned) - is it better to avoid
> > potential conversion issues with an 'int'?
>
> struct rmp_state.asid is already u32 but yeah, lemme fix that.

Btw,

static int sev_get_asid(struct kvm *kvm)
{
struct kvm_sev_info *sev = &to_kvm_svm(kvm)->sev_info;

return sev->asid;
}

whereas

struct kvm_sev_info {
...
unsigned int asid; /* ASID used for this guest */

so that function needs fixing too.

Thx.

--
Regards/Gruss,
Boris.