public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
	thuth@redhat.com, david@redhat.com, nsg@linux.ibm.com,
	nrb@linux.ibm.com
Subject: [kvm-unit-tests PATCH v2 0/5] s390x: Dirty cc before executing tested instructions
Date: Wed, 31 Jan 2024 07:44:22 +0000	[thread overview]
Message-ID: <20240131074427.70871-1-frankja@linux.ibm.com> (raw)

A recent s390 KVM fixpatch [1] showed us that checking the cc is not
enough when emulation code forgets to set the cc. There might just be
the correct cc in the PSW which would make the cc check succeed.

This series intentionally dirties the cc for sigp, uvc, some io
instructions and sclp to make cc setting errors more apparent. I had a
cursory look through the tested instructions and those are the most
prominent ones with defined cc values.

Since the issue appeared in PQAP my AP test series is now dependent on
this series.

[1] https://lore.kernel.org/kvm/20231201181657.1614645-1-farman@linux.ibm.com/

v2:
	* Moved from spm to tmll (thanks Nina)

Janosch Frank (5):
  lib: s390x: sigp: Dirty CC before sigp execution
  lib: s390x: uv: Dirty CC before uvc execution
  lib: s390x: css: Dirty CC before css instructions
  s390x: mvpg: Dirty CC before mvpg execution
  s390x: sclp: Dirty CC before sclp execution

 lib/s390x/asm/sigp.h |  6 +++++-
 lib/s390x/asm/uv.h   |  4 +++-
 lib/s390x/css.h      | 16 ++++++++++++----
 s390x/mvpg.c         |  6 ++++--
 s390x/sclp.c         |  5 ++++-
 5 files changed, 28 insertions(+), 9 deletions(-)

-- 
2.40.1


             reply	other threads:[~2024-01-31  7:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31  7:44 Janosch Frank [this message]
2024-01-31  7:44 ` [kvm-unit-tests PATCH v2 1/5] lib: s390x: sigp: Dirty CC before sigp execution Janosch Frank
2024-01-31 11:56   ` Claudio Imbrenda
2024-01-31 14:16     ` Janosch Frank
2024-01-31  7:44 ` [kvm-unit-tests PATCH v2 2/5] lib: s390x: uv: Dirty CC before uvc execution Janosch Frank
2024-01-31 11:50   ` Claudio Imbrenda
2024-01-31  7:44 ` [kvm-unit-tests PATCH v2 3/5] lib: s390x: css: Dirty CC before css instructions Janosch Frank
2024-01-31  7:44 ` [kvm-unit-tests PATCH v2 4/5] s390x: mvpg: Dirty CC before mvpg execution Janosch Frank
2024-01-31  7:44 ` [kvm-unit-tests PATCH v2 5/5] s390x: sclp: Dirty CC before sclp execution Janosch Frank
2024-02-01 17:49 ` [kvm-unit-tests PATCH v2 0/5] s390x: Dirty cc before executing tested instructions Claudio Imbrenda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240131074427.70871-1-frankja@linux.ibm.com \
    --to=frankja@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=nrb@linux.ibm.com \
    --cc=nsg@linux.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox