From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58D5116F850 for ; Fri, 5 Apr 2024 14:31:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712327501; cv=none; b=gQTZeH+RiLrvZMbs4WC809yBAHjOKTFFWlBXgbsap97uj0k/vI6eezTXtfJz2daKhnBIzs8f4nSNBDwko4t1D9PIZHAXfzVGaPFWXgQcrWYC9ufIcoCB+7juWgBHLL6lNgFmIXYaIXXsXQTMeHrBXr9XEIaMFY/FQisHy3REaMo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712327501; c=relaxed/simple; bh=dNygJby67Cdvcvl0y7n21FxTGIpVy868gYWkMjcWU6w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RPW7CsG/STSAGWWXZkfAS/13RjI9yu3QxyumvnayOdziqpPQ/dbbM3H7jK9hEs+fWAgxHEiLklVw3xhys8pPTAjkc/rDmlksJU8HQ7J8nqYsRycXXX8lN4eulE+OGKmWTIobuBs4gaewlb8WqGWpzeOSobH/Oo0jLDdlBlWTE24= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=GErPDrev; arc=none smtp.client-ip=95.215.58.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="GErPDrev" Date: Fri, 5 Apr 2024 16:31:35 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1712327498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8/xOkaTxQ2aUEU42TOlQF76gpDIp/PIEB5q35o4B6vI=; b=GErPDrevJpRO8nnYKRAF4gRl8e52qeyAMUbhmhoExGHDdDbI0beoLh2ifwbxpZ0uzLAToy 8aRj7nXqSlADLwnz5yRlJKohEZXXiTiFy7uXtag0GWkT0CXU8VMaCu8xGU3K19dSFEseOF nziKaWk4K3NWS26sMPRWX8oPWfUaghk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Andrew Jones To: Nicholas Piggin Cc: Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , Nico =?utf-8?B?QsO2aHI=?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , Nadav Amit , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [kvm-unit-tests RFC PATCH 10/17] shellcheck: Fix SC2013 Message-ID: <20240405-0a2cfafb045613943c8d3162@orel> References: <20240405090052.375599-1-npiggin@gmail.com> <20240405090052.375599-11-npiggin@gmail.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240405090052.375599-11-npiggin@gmail.com> X-Migadu-Flow: FLOW_OUT On Fri, Apr 05, 2024 at 07:00:42PM +1000, Nicholas Piggin wrote: > SC2013 (info): To read lines rather than words, pipe/redirect to a > 'while read' loop. > > Not a bug. > > Signed-off-by: Nicholas Piggin > --- > scripts/arch-run.bash | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash > index 9dc34a54a..e5750cb98 100644 > --- a/scripts/arch-run.bash > +++ b/scripts/arch-run.bash > @@ -487,7 +487,7 @@ env_file () > > [ ! -f "$KVM_UNIT_TESTS_ENV_OLD" ] && return > > - for line in $(grep -E '^[[:blank:]]*[[:alpha:]_][[:alnum:]_]*=' "$KVM_UNIT_TESTS_ENV_OLD"); do > + grep -E '^[[:blank:]]*[[:alpha:]_][[:alnum:]_]*=' "$KVM_UNIT_TESTS_ENV_OLD" | while IFS= read -r line ; do > var=${line%%=*} > if ! grep -q "^$var=" $KVM_UNIT_TESTS_ENV; then > eval export "$line" > -- > 2.43.0 > Reviewed-by: Andrew Jones