From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8B1416D318 for ; Fri, 5 Apr 2024 14:38:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712327893; cv=none; b=EyBCTc298UONkmO+C8t9riiljqa/0pDktP+otsJH2sbx2WRKj4mBf/mpaqhJW2ZP2s6B0eZebec7kwtzK/yqkIKSqTNpaIgGYPQ3LA51DSfpZHbtrCxbgBPOnrE4oJPR72U2/9MBM+z7BtGbjW43NV2qbmIidBjNK6S7NI83zKM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712327893; c=relaxed/simple; bh=PcBChv9MOzGSgT6JiR9lSFomnhCQx4x27lSG6SsaEk8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Nz3erqdw5S2+zlVU2smcAUMoKoFLvAySa/xJAVyUKJUBuKY74gpazwHIxVd0MqYrMDrDb9UNqGAsuNTd7B+pMk8y/bSSIcF8pMZGWzzPFiIVJLKONB8QljuB+M+UXbWNgxi8XwKW3lhmaqt0AkANop33++tD/GAe/EY6XeC33gs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=L15hda2r; arc=none smtp.client-ip=91.218.175.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="L15hda2r" Date: Fri, 5 Apr 2024 16:38:07 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1712327890; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ba8wk7hPVgFRaxodfX5xG0+Os8iu9mUKIoqeWMmz5aw=; b=L15hda2rIOaCRvZBK3vqh8fTYR4wgUxh8/XJQIa4vLguxK6PHeCN3QS6pbvXq50KFoDeYx Gf1/tumQ+0/THe2+Tue/JW8hi5WKawqt32Mqu+Teb0HKg+Krh9bJDKT87ebHrvlzRqXNpe PiUaRyNkK1OA/NejrXxrOxI12IccH68= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Andrew Jones To: Nicholas Piggin Cc: Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , Nico =?utf-8?B?QsO2aHI=?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , Nadav Amit , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [kvm-unit-tests RFC PATCH 13/17] shellcheck: Fix SC2294 Message-ID: <20240405-469e12c137e05d64ecf337bb@orel> References: <20240405090052.375599-1-npiggin@gmail.com> <20240405090052.375599-14-npiggin@gmail.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240405090052.375599-14-npiggin@gmail.com> X-Migadu-Flow: FLOW_OUT On Fri, Apr 05, 2024 at 07:00:45PM +1000, Nicholas Piggin wrote: > SC2294 (warning): eval negates the benefit of arrays. Drop eval to > preserve whitespace/symbols (or eval as string). > > No bug identified. > > Signed-off-by: Nicholas Piggin > --- > scripts/arch-run.bash | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash > index 89a496014..ed440b4aa 100644 > --- a/scripts/arch-run.bash > +++ b/scripts/arch-run.bash > @@ -179,7 +179,7 @@ run_migration () > exec {src_infifo_fd}<>${src_infifo} > exec {dst_infifo_fd}<>${dst_infifo} > > - eval "${migcmdline[@]}" \ > + "${migcmdline[@]}" \ > -chardev socket,id=mon,path=${src_qmp},server=on,wait=off \ > -mon chardev=mon,mode=control \ > < ${src_infifo} > ${src_outfifo} & > @@ -219,7 +219,7 @@ run_migration () > > do_migration () > { > - eval "${migcmdline[@]}" \ > + "${migcmdline[@]}" \ > -chardev socket,id=mon,path=${dst_qmp},server=on,wait=off \ > -mon chardev=mon,mode=control -incoming unix:${dst_incoming} \ > < ${dst_infifo} > ${dst_outfifo} & > @@ -357,7 +357,7 @@ run_panic () > qmp=$(mktemp -u -t panic-qmp.XXXXXXXXXX) > > # start VM stopped so we don't miss any events > - eval "$@" -chardev socket,id=mon,path=${qmp},server=on,wait=off \ > + "$@" -chardev socket,id=mon,path=${qmp},server=on,wait=off \ > -mon chardev=mon,mode=control -S & > > panic_event_count=$(qmp_events ${qmp} | jq -c 'select(.event == "GUEST_PANICKED")' | wc -l) > -- > 2.43.0 > Reviewed-by: Andrew Jones