From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CF0316EC01 for ; Fri, 5 Apr 2024 14:40:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.187 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712328014; cv=none; b=JGg4riNCktt7BOyFkm+Gv6or2+k2G72+vfulPDqCyGYC9QBphDcl7eSBjcqewDM1sipAoT+NRbTmEIVdTjGLkozMqgECl/BjGvwMYJRfWUM2IecxX9RFDd4L+ZnGA+U9MVVdSqbhAVIGKOATgPP+4yUWDz2M3JDre5FcXDvIPpQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712328014; c=relaxed/simple; bh=IRs0UkLzOvLLelINCiwEurKEPkUrDXUtVEMOnZiHPSM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p1yIZXFLkvgbzD2DrySGNPspyEjNk/6t5ZwBU1wywrBYuFw8HxYO2OnvvPvZE38CFwupgpve9YLaY6RJ5KXck0jbQkrWsLO1HqT/mPOKAVjET1h3yBDSBpctuXcUb14dlR1Cx+fSccy9BEop8TiO3BwkDJSLXPUbvKMPDZhLLZo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=iCRmchau; arc=none smtp.client-ip=95.215.58.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="iCRmchau" Date: Fri, 5 Apr 2024 16:40:06 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1712328009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KHy1FBeT0P7q2ACiIwc24lYZLxTgKK8Ca1uNIPNsdOw=; b=iCRmchauY3Jz8V4SeQVpgg9SpT9EiCMnKjZGYlgTSIHm2BYxD1rHlOTByj9BmO+EfkFdyA uXLitQS5bSNKvvZriCTT7RmJZ6rrhDnI0sWBqNbkHKOB9XtMZ7Iwz0LMFsNYLHceToH0MF dyL57/8oZrL1vi+RQwO7HyjKe7Ux1Pk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Andrew Jones To: Nicholas Piggin Cc: Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , Nico =?utf-8?B?QsO2aHI=?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , Nadav Amit , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [kvm-unit-tests RFC PATCH 14/17] shellcheck: Fix SC2178 Message-ID: <20240405-4dc7c31121a4214d2efb9edc@orel> References: <20240405090052.375599-1-npiggin@gmail.com> <20240405090052.375599-15-npiggin@gmail.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240405090052.375599-15-npiggin@gmail.com> X-Migadu-Flow: FLOW_OUT On Fri, Apr 05, 2024 at 07:00:46PM +1000, Nicholas Piggin wrote: > SC2178 (warning): Variable was used as an array but is now assigned a > string. > > Not sure if there's a real bug. Things seem to work, but the change looks better. > > Signed-off-by: Nicholas Piggin > --- > arm/efi/run | 2 +- > riscv/efi/run | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arm/efi/run b/arm/efi/run > index cf6d34b0b..8f41fc02d 100755 > --- a/arm/efi/run > +++ b/arm/efi/run > @@ -44,7 +44,7 @@ qemu_args=() > cmd_args=() > while (( "$#" )); do > if [ "$1" = "-append" ]; then > - cmd_args=$2 > + cmd_args=("$2") > shift 2 > else > qemu_args+=("$1") > diff --git a/riscv/efi/run b/riscv/efi/run > index cce068694..5a72683a6 100755 > --- a/riscv/efi/run > +++ b/riscv/efi/run > @@ -47,7 +47,7 @@ qemu_args=() > cmd_args=() > while (( "$#" )); do > if [ "$1" = "-append" ]; then > - cmd_args=$2 > + cmd_args=("$2") > shift 2 > else > qemu_args+=("$1") > -- > 2.43.0 > Reviewed-by: Andrew Jones