From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F130E1EEFC for ; Sat, 6 Apr 2024 07:30:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712388613; cv=none; b=kcz1vivjHjSB7Ow/cSXmuJ/VTjvqt+J7afvhfYBdJrDsQ2Ww++pNO5zcpOalCPxaEbGg8JhYPEy8EzKuuUt+5uZei7EzPny/1+TFtaxOo114el4SRElOHqsVtcTNqdS7NEKMUoAZWlozwtuuL9ohS0iOkaGW+w3PQSUU+CvoFww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712388613; c=relaxed/simple; bh=EiOLesEbfUDQbQH025YsSHxrXoch1GdDr36PdIuC1wU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oh8fOb86RjIV5IbaIo5xwjvf4EXhvdnFYWvRgRk+0hwxew44IZnYlNl3dTUxY7z7K2umVufvwVTUcibqjptEBBe4ef8Z3d0A4c/Grk92eTA0bjmFIKDk4s3xlJQFUOl+wVNz0p/lsccEbqGnVCorrlwjlAYIGcz9zVvHyHEFct0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=VONH2XnX; arc=none smtp.client-ip=95.215.58.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="VONH2XnX" Date: Sat, 6 Apr 2024 09:30:02 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1712388606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A4VClCDgGsrOijiN2aMuip12kqj4B5e5rGZ9WIheBfg=; b=VONH2XnXTurq1b4ktKNCxBCYal3GcE+yz2Vucv9y8WMdGgAoCYzXy9UIQLEhU6F34EvLlj I5b4rHwGMUffE4y9iieUdna92U3I+99Gm+PVEdC6cnunBUuVjA3DGaQE7eBlJwCB/IYXlX A7k5tuLcKoavDA4/Ajjrx2yOimRyFr8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Andrew Jones To: Nicholas Piggin Cc: Paolo Bonzini , Thomas Huth , Alexandru Elisei , Eric Auger , Janosch Frank , Claudio Imbrenda , Nico =?utf-8?B?QsO2aHI=?= , David Hildenbrand , Shaoqin Huang , Nikos Nikoleris , Nadav Amit , David Woodhouse , Ricardo Koller , rminmin , Gavin Shan , Nina Schoetterl-Glausch , Sean Christopherson , kvm@vger.kernel.org, kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [kvm-unit-tests RFC PATCH 17/17] shellcheck: Suppress various messages Message-ID: <20240406-35a566d73057343e596e0fc9@orel> References: <20240405090052.375599-1-npiggin@gmail.com> <20240405090052.375599-18-npiggin@gmail.com> <20240405-7c0ad5d3ce76e1ad9ad2f5a9@orel> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT On Sat, Apr 06, 2024 at 04:31:17PM +1000, Nicholas Piggin wrote: ... > > > diff --git a/scripts/runtime.bash b/scripts/runtime.bash > > > index 3b76aec9e..c87613b96 100644 > > > --- a/scripts/runtime.bash > > > +++ b/scripts/runtime.bash > > > @@ -137,6 +137,8 @@ function run() > > > # the check line can contain multiple files to check separated by a space > > > # but each check parameter needs to be of the form = > > > if [ "$check" ]; then > > > + # There is no globbing allowed in the check parameter. > > > + # shellcheck disable=SC2206 > > > check=($check) > > > > Hmm, I'm not sure about this one. $check is an arbitrary path, which means > > it can have spaces, then =, and then an arbitrary value, which means it can > > contain spaces. If there are multiple check path=value pairs then > > separation by space is a bad idea, and any deliminator really is. It seems > > like each pair should be quoted, i.e. > > > > check = "path1=value1" "path2=value2" > > > > and then that should be managed here. > > Yeah I did think of that, valid paths could also have = and ", and even > with double quotes it seems to be tricky to handle spaces. > > Maybe I'll just add to the unittest.cfg docs to stick with alphanumeric > paths, and we can improve it if someone complains? Works for me. Thanks, drew